From 078f083a5f16ae9deefa565881d4adc9727bd839 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 16:24:51 +0000 Subject: [PATCH 1/2] Initial plan From 53b7b4fa3bfdc7c2a3cad09707ac02ceb809d303 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 1 Apr 2026 16:41:09 +0000 Subject: [PATCH 2/2] test: add generateRows and CUSTOM fallback tests to GeneratorServiceTest Agent-Logs-Url: https://github.com/MaximumTrainer/OpenDataMask/sessions/2e36f54b-a0a6-4558-b763-5a09dde079bb Co-authored-by: MaximumTrainer <1376575+MaximumTrainer@users.noreply.github.com> --- .../service/GeneratorServiceTest.kt | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/backend/src/test/kotlin/com/opendatamask/service/GeneratorServiceTest.kt b/backend/src/test/kotlin/com/opendatamask/service/GeneratorServiceTest.kt index 70edeeb..99531bf 100644 --- a/backend/src/test/kotlin/com/opendatamask/service/GeneratorServiceTest.kt +++ b/backend/src/test/kotlin/com/opendatamask/service/GeneratorServiceTest.kt @@ -106,4 +106,33 @@ class GeneratorServiceTest { assertEquals("masked@example.com", result["email"]) assertEquals(1, result["id"]) } + + @Test + fun `generateRows produces the requested number of rows`() { + val generators = listOf( + ColumnGenerator(tableConfigurationId = 1L, columnName = "name", generatorType = GeneratorType.NAME), + ColumnGenerator(tableConfigurationId = 1L, columnName = "email", generatorType = GeneratorType.EMAIL) + ) + val rows = service.generateRows(generators, 3) + assertEquals(3, rows.size) + rows.forEach { row -> + assertTrue((row["name"] as String).isNotBlank()) + assertTrue((row["email"] as String).contains("@")) + } + } + + @Test + fun `generateRows returns empty list when count is zero`() { + val generators = listOf( + ColumnGenerator(tableConfigurationId = 1L, columnName = "name", generatorType = GeneratorType.NAME) + ) + val rows = service.generateRows(generators, 0) + assertTrue(rows.isEmpty()) + } + + @Test + fun `CUSTOM falls back to originalValue when no params provided`() { + val result = service.generateValue(GeneratorType.CUSTOM, "fallback", null) + assertEquals("fallback", result) + } }