Skip to content

Commit 002deb3

Browse files
Do consider pull requests from @arm.com authors
The heuristic that @arm.com = PR by the team and PR by the team = low likelihood of a missing changelog is not particularly correct nowadays. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
1 parent bbec334 commit 002deb3

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

tools/bin/mbedtls-check-missing-changelog

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ This script uses heuristics:
1212
revision range.
1313
* Pull requests that modify ChangeLog or ChangeLog.d in any way are assumed
1414
to be ok.
15-
* Pull requests whose last commit before merging has an @arm.com author
16-
are assumed to be team PR where we put a changelog entry if necessary.
1715
EOF
1816
}
1917

@@ -29,9 +27,6 @@ fi
2927
revision_range=$1
3028
merge_commits=$(git log --merges --first-parent --format=%H $revision_range)
3129
for c in $merge_commits; do
32-
if [[ $(git log -n1 --format=%ae $c\^2) == *@arm.com ]]; then
33-
continue
34-
fi
3530
if git diff --name-only $c~1 $c | grep -q ChangeLog; then
3631
continue
3732
fi

0 commit comments

Comments
 (0)