Move mbedtls_dev to mbedtls_framework in the framework repo
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Add ALPN information in session tickets
Add testing for concurrently loading/using/destroying the same key
Expand MSVC to Visual Studio and announce the moving of the solution files. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
All supported versions of Visual Studio support AESNI, so drop the version number. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>
Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>
…ompat-tests TLS 1.3: Resumption and early data compatibility tests
Test the behavior of mbedtls_pk_get_psa_attributes() and
mbedtls_pk_import_into_psa() with respect to lifetime. In particular, test
that they work with persistent keys as documented.
Test cases generated by the following script:
```
for old in [('transparent', '0:0:1'),
('opaque volatile [export]', '1:0:1'),
('opaque volatile [copy]', '1:0:0'),
('opaque persistent [export]', '1:1:1'),
('opaque persistent [copy]', '1:1:0')]:
for to_public in [('pair', '0'),
('public', '1')]:
for to_persistent in [('volatile', '0'),
('persistent', '1')]:
depends = ('\ndepends_on:MBEDTLS_USE_PSA_CRYPTO'
if old[0].startswith('opaque')
else '')
print(f"""\
PSA import into PSA: {old[0]} -> {to_persistent[0]} {to_public[0]}{depends}
pk_import_into_psa_lifetime:{old[1]}:{to_public[1]}:{to_persistent[1]}
""")
```
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Drop Support for MSVC 2013, 2015 and Arm Compiler 5
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
…-nego-testing TLS: Improve server version negotiation testing
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
…eiving-early-data Check ALPN when receiving early data
Catch potential invalid calls to init. Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
TLS 1.3: Documentation update for 3.6 release
Adds missing transition and italicises internal functions Signed-off-by: Ryan Everett <ryan.everett@arm.com>
A few typo fixes, extrapolations and extra details. Signed-off-by: Ryan Everett <ryan.everett@arm.com>
Make PSA global_data thread safe
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
…est-lifetime pk_import_into_psa: test persistent keys
Co-authored-by: Paul Elliott <62069445+paul-elliott-arm@users.noreply.github.com> Signed-off-by: Ryan Everett <ryan.everett@arm.com>
Add changelog entry for threading MVP
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
ChangeLog: Add missing reference to CVE in security entry
…lot-threading-bug Wipe the returned slot pointer upon failure in `psa_get_and_lock_key_slot`
…g-for-secure-element-keys-in-psa_start_key_creation Fix error handling for secure element keys in `psa_start_key_creation`
ssl_mail_client: Fix unbounded write of sprintf()
Undefined reference to mbedtls_md_error_from_psa() function
davidhorstmann-arm
added
needs-work
needs-preceding-pr
davidhorstmann-arm
changed the title
mbedtls_dev to mbedtls_framework in the framework modulembedtls_dev to mbedtls_framework in the framework repo
Signed-off-by: David Horstmann <david.horstmann@arm.com>
…mann-arm/add-mbedtls-framework-module
Signed-off-by: David Horstmann <david.horstmann@arm.com>
davidhorstmann-arm
force-pushed
the
dev/davidhorstmann-arm/add-mbedtls-framework-module
branch
from
435c1a5 to
7c58bc6
Compare
4 tasks
davidhorstmann-arm
added
needs-review
ronald-cron-arm
approved these changes
May 13, 2024
Contributor
ronald-cron-arm
left a comment
ronald-cron-arm
left a comment
There was a problem hiding this comment.
LGTM in association to #9094.
ronald-cron-arm
removed
the
needs-reviewer
bensze01
approved these changes
May 27, 2024
Contributor
bensze01
left a comment
bensze01
left a comment
There was a problem hiding this comment.
Looks good to me as well!
bensze01
added
approved
davidhorstmann-arm
pushed a commit
that referenced
this pull request
May 29, 2024
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
davidhorstmann-arm
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
See also Mbed-TLS/mbedtls#9094
Move files from
mbedtls_devintombedtls_frameworkwhile preserving their histories. Do this by taking thembedtlsrepository and deleting all files except the ones we want to move, then merging this branch into thembedtls-frameworkrepository.This operation was automated via the script in Mbed-TLS/mbedtls-docs#145