PlayerSay and PlayerCanSeePlayersChat problems

[Earu]

https://github.com/MechanicalMind/murder/blob/master/gamemode/sv_player.lua#L473
In the above file, in your PlayerSay override, you call the PlayerCanSeePlayersChat hook and return a boolean.

1. PlayerCanSeePlayersChat is called after PlayerSay because the PlayerSay hook can modify a player message, the string is then passed to PlayerCanSeePlayersChat. To test this behavior I invite you to test the following code server-side in sandbox:

hook.Add("PlayerSay","test",function(...)
	return "test"
end)

hook.Add("PlayerCanSeePlayersChat","test",print)

2. PlayerSay return type is a string, not a boolean.

Those behaviors are issues for addon makers because they're unexpected behaviors since they do not follow the base gamemode function signatures.

[MechanicalMind]

I understand issue 2, but I'm not sure what the problem is with 1?
The point is the hide the default chat message, to replace it with a custom one, but still allows addon makers to hide the custom chat messages.

[Earu]

Well the problem in issue one is that because PlayerCanSeePlayersChat receives a "unmodified" version of the player message then addons hooking into it might have inconsistencies between murder and sandbox / base gamemode.

If I have this code:

hook.Add("PlayerSay","filter",function(ply,txt)
    if txt:match("bad word") then
        return "TOBEREMOVED"
    end
end)

hook.Add("PlayerCanSeePlayersChat ","filter",function(txt)
    if txt == "TOBEREMOVED" then return false end
end)

In murder this would not work because instead of receiving "TOBEREMOVED" we would receive "bad word" in the PlayerCanSeePlayersChat hook.
Of course this is only to demonstrate how this could break some things, I am aware that there are better ways to do this.