Randomium incompatible with Fancy Entity Renderer

[ItzDabbzz]

Randomium triggers creative mod tab rebuild in the main menu, which makes it incompatible with Fancy Entity Renderer for Fancy Menu.
When any world loads up (including FER mock up world), NeoForge posts an event, and Randomium triggers creative mod tab rebuild, which in turn calls stuff from Create QoL and makes the game crash

I've been trying to fix this issue with CrystalSpider the developer of FER, and just getting stuck here.

FER Modrinth Link
FER Github LInk

error_split.txt
debug.log

I know its also erroring out on Create QOL, but if i remove it, it still errors out on Randomium

[MehVahdJukaar]

It's their issue. That method is not client specific. If their mod makes assumptions and calls client side stuff in a common method is 100% their fault

[MehVahdJukaar]

Report to whoever code it's erroring, I'm just calling vanilla method with valid parameters and all

[ItzDabbzz]

I already have been working with them, the told me to contact you.

[MehVahdJukaar]

Obviously it's not their issue. I meant create qol. It's their issue. It's not that config isn't loaded it's that it never will be as it's a client config accessed from server side logic. They are assuming creative stuff is client side which it isnt

[ItzDabbzz]

ohh my bad, i made a issue report on their page as well iglee42/CreateQualityOfLife#61 . Thanks for clarifying though.

[MehVahdJukaar]

I changed my mind, its likely its a Fancy Entity Renderers issue. They are creating a world at an unconventioanl time, too early one might say. Still thats valid and one can do that but one has to be careful to load all things required for the world. Here it becomes tricky, normally the game loads the configs on boot but there are some that are loaded in world load, (normal world load I guess?) it might be possible that here they arent loaded with their custom level. And loading a new level can and will trigger many events, even from rendring an entity I could access my config. If these configs are not in the same state they would be when a normal world load it seems to me that would be their issue

[ItzDabbzz]

@Crystal-Spider can give more input on this, as they are the developer of FER https://github.com/Crystal-Spider

[Crystal-Spider]

I would be very glad to do something about it, but I have no idea what I could do.
I don't think I have any control over when configs get loaded.

Luckily, since 1.21.3, with the introduction of render states, I don't need any mock client or player, so this issue is present only in 1.21.1.

[MehVahdJukaar]

well when rendering anything mods could very well read their own configs. honestly i dont really understand what the issue is as the client and comon configs are loaded as the game loads, after blocks are registered. when does your stuff happen and what kind of configs are giving an error here?

[MehVahdJukaar]

we believe that issue is from create QOL using server configs for some possibly client logic

[Crystal-Spider]

My mock-up world is loaded when a FancyPlayerWidget instance is created, and this depends on Fancy Menu, so I don't know the exact timing.
The line that creates the error is this one, which indeed seems to call server-side config although the mock-up world is a ClientLevel.

[ItzDabbzz]

we believe that issue is from create QOL using server configs for some possibly client logic

I removed Create QOL, and nearly every single Create addon, yet it still crashed with Create and Randomium as the two suspects.

I removed Randomium, and then everything works just fine, so something about Create + Randomium + FER do not like each other

DebugLog

[MehVahdJukaar]

ok so since a moc wold created in the main screen (I assume), and server configs dont exist there yet, that would be the core o the issue. Mods could access those arbitrairly at any point of their code while rendering stuff and such. ALso to note the server config name is misleading. these are the only config type that's synced by forge from server to client, on connection.
So again i think the actual issue is that this making a world in the main screen can lead to some chain of events which can allow mods to call their configs.
So either try to cut out that chain, perhaps by not firing all the events that start from that level , or find a way to create other moc object for the configs. When i made my FakeServerLevel i remember i had to do so many moc objects to go around it just to function