Running both asynchronous and synchronous queries at the same time causes transaction to fail

[wyozi]

Basically doing the following causes both of the queries to run at the same time, and hence causing the synchronous transaction to fail due to the async query's transaction being open.

local asyncQ = pg:query("do something that takes a while");
asyncQ:run()

local syncQ = pg:query("SELECT 1");
syncQ:set_sync(true)
local b, reason = syncQ:run()
assert(b == false)
-- reason = Started transaction<READ COMMITTED> while transaction<READ COMMITTED> still active

This is quite a corner case, and will be solved for me as well when I'm able to safely migrate all queries to use asynchronous mode, but thought I'd report it anyway.

[Meow]

Thanks for reporting this issue, I'll look into fixing it.

[wyozi]

FWIW this is fixed in my fork: https://github.com/wyozi-gmod/gmsv_pg

I did a lot of things differently and removed some code, so I'm not sure how easy my changes would be to merge upstream. If my changes keep working I'll see if I can create small mergeable patches.

local asyncQ = pg:query("SELECT pg_sleep(1)");
asyncQ:on("success", print)
asyncQ:run()

local syncQ = pg:query("SELECT 1");
local b, reason = syncQ:run_sync()
print(b, reason)

[Meow]

One of the goals of my module Is to be as compatible as possible, which means using C++11 and the oldest compilers that have support for it. I'll see if I can implement something similar with it tho, thank you for doing this work.