Skip to content

Code Quality: Resolve ESLint violations and remove dead code #102

@DarthMarino

Description

@DarthMarino

Overview

Several files have unsolved ESLint violations and unused code that should be cleaned up/commented to improve maintainability and keep the codebase consistent and clean.

Inmediate gains

Cleaning the project will improve readability for future contributors and, at the same time, ensure proper formatting.

ESLint Violations

Naming conventions (@typescript-eslint/naming-convention)

  • CustomSkeletonHelper.ts and CustomViewHelper.ts use camelCase variable names instead of the project's required snake_case (these appear to be adapted Three.js utilities).

Unused variables (@typescript-eslint/no-unused-vars)

  • CustomModelUploadBootstrap.tsapp
  • Mesh2MotionEngine.tsBoneTesterData, SkeletonType, closest_bone_index

Strict boolean expressions (@typescript-eslint/strict-boolean-expressions)

  • any values used in conditionals without explicit null/type checks across CustomSkeletonHelper.ts, EventListeners.ts, and others.

Formatting

  • Brace style, spacing around operators, blank lines, and indentation issues scattered across Mesh2MotionEngine.ts and Generators.ts.

Reproduction

  • npx eslint src/ --ext .ts shows all the ESLint errors.
  • CustomSkeletonHelper.ts and CustomViewHelper.ts should either conform to naming rules or have targeted ESLint disable comments with justification (since they come from the Three.js source).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions