Overview
Several files have unsolved ESLint violations and unused code that should be cleaned up/commented to improve maintainability and keep the codebase consistent and clean.
Inmediate gains
Cleaning the project will improve readability for future contributors and, at the same time, ensure proper formatting.
ESLint Violations
Naming conventions (@typescript-eslint/naming-convention)
CustomSkeletonHelper.ts and CustomViewHelper.ts use camelCase variable names instead of the project's required snake_case (these appear to be adapted Three.js utilities).
Unused variables (@typescript-eslint/no-unused-vars)
CustomModelUploadBootstrap.ts — app
Mesh2MotionEngine.ts — BoneTesterData, SkeletonType, closest_bone_index
Strict boolean expressions (@typescript-eslint/strict-boolean-expressions)
any values used in conditionals without explicit null/type checks across CustomSkeletonHelper.ts, EventListeners.ts, and others.
Formatting
- Brace style, spacing around operators, blank lines, and indentation issues scattered across
Mesh2MotionEngine.ts and Generators.ts.
Reproduction
npx eslint src/ --ext .ts shows all the ESLint errors.
CustomSkeletonHelper.ts and CustomViewHelper.ts should either conform to naming rules or have targeted ESLint disable comments with justification (since they come from the Three.js source).
Overview
Several files have unsolved ESLint violations and unused code that should be cleaned up/commented to improve maintainability and keep the codebase consistent and clean.
Inmediate gains
Cleaning the project will improve readability for future contributors and, at the same time, ensure proper formatting.
ESLint Violations
Naming conventions (
@typescript-eslint/naming-convention)CustomSkeletonHelper.tsandCustomViewHelper.tsuse camelCase variable names instead of the project's required snake_case (these appear to be adapted Three.js utilities).Unused variables (
@typescript-eslint/no-unused-vars)CustomModelUploadBootstrap.ts—appMesh2MotionEngine.ts—BoneTesterData,SkeletonType,closest_bone_indexStrict boolean expressions (
@typescript-eslint/strict-boolean-expressions)anyvalues used in conditionals without explicit null/type checks acrossCustomSkeletonHelper.ts,EventListeners.ts, and others.Formatting
Mesh2MotionEngine.tsandGenerators.ts.Reproduction
npx eslint src/ --ext .tsshows all the ESLint errors.CustomSkeletonHelper.tsandCustomViewHelper.tsshould either conform to naming rules or have targeted ESLint disable comments with justification (since they come from the Three.js source).