Skip to content

Commit 4bc7432

Browse files
committed
chore: Temporarily disable @typescript-eslint/naming-convention
The rule `@typescript-eslint/naming-convention` was already disabled for most files, but it was set to `warn` in a few places still. It's now completely disabled instead. This was done to reduce the set of changes that are part of the upcoming switch to error suppression (#6790), and also for consistency. We still want to use this rule, but we can gradually begin enforcing it in a more controlled manner using error suppression, across the entire repository at once rather than selectively.
1 parent 9ef4ca0 commit 4bc7432

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

eslint-warning-thresholds.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,11 @@
101101
"@typescript-eslint/unbound-method": 5,
102102
"no-restricted-syntax": 28
103103
},
104-
"packages/eth-block-tracker/tests/buildDeferred.ts": {
105-
"@typescript-eslint/naming-convention": 1
106-
},
107104
"packages/eth-block-tracker/tests/recordCallsToSetTimeout.ts": {
108105
"@typescript-eslint/no-explicit-any": 1
109106
},
110107
"packages/eth-block-tracker/tests/setupAfterEnv.ts": {
111108
"@typescript-eslint/consistent-type-definitions": 1,
112-
"@typescript-eslint/naming-convention": 1,
113109
"@typescript-eslint/no-explicit-any": 3
114110
},
115111
"packages/eth-block-tracker/tests/withBlockTracker.ts": {

eslint.config.mjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ const config = createConfig([
188188
{
189189
files: ['**/*.d.ts'],
190190
rules: {
191-
'@typescript-eslint/naming-convention': 'warn',
192191
'import-x/unambiguous': 'off',
193192
},
194193
},
@@ -224,7 +223,6 @@ const config = createConfig([
224223
// TODO: Re-enable these rules or add inline ignores for warranted cases
225224
'@typescript-eslint/prefer-nullish-coalescing': 'warn',
226225
'no-restricted-syntax': 'warn',
227-
'@typescript-eslint/naming-convention': 'warn',
228226
'@typescript-eslint/no-explicit-any': 'warn',
229227
'@typescript-eslint/unbound-method': 'warn',
230228
'@typescript-eslint/consistent-type-definitions': 'warn',

types/global.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ declare global {
55
// We're using `interface` here so that we can extend and not override it.
66
// In addition, we must use the generic parameter name `R` to match the
77
// Jest types.
8-
// eslint-disable-next-line @typescript-eslint/consistent-type-definitions,@typescript-eslint/naming-convention
8+
// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
99
interface Matchers<R> {
1010
toBeFulfilled(): Promise<R>;
1111
toNeverResolve(): Promise<R>;

0 commit comments

Comments
 (0)