Skip to content

Commit 800e615

Browse files
GudahttGudahtt
authored
chore: Update ESLint config to v14.1.0 (#7103)
## Explanation Update ESLint config packages to v14.1.0. The rule `jest/unbound-method` has been temporarily disabled. This is a looser version of `@typescript-eslint/unbound-method`, which was already disabled. We can attempt enabling both at the same time when we're ready. ## References N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates ESLint config packages to 14.1.0, disables `jest/unbound-method`, and refreshes lint warning thresholds. > > - **ESLint Config**: > - Bump `@metamask/eslint-config`, `@metamask/eslint-config-jest`, and `@metamask/eslint-config-typescript` to `^14.1.0` in `package.json` and `yarn.lock`. > - In `eslint.config.mjs`, disable `jest/unbound-method` for test files. > - **Lint Warning Thresholds** (`eslint-warning-thresholds.json`): > - Adjust counts and remove several entries for `packages/eth-block-tracker/**` (e.g., drop `@typescript-eslint/naming-convention` thresholds and `BlockTracker.ts` entry). > - Reduce `@typescript-eslint/prefer-promise-reject-errors` threshold in `packages/json-rpc-middleware-stream/src/index.test.ts` from 3 to 1. > - Misc minor threshold updates across packages to align with new config. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 917ea15. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent bd65e7f commit 800e615

File tree

4 files changed

+26
-29
lines changed

4 files changed

+26
-29
lines changed

‎eslint-warning-thresholds.json‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -159,15 +159,10 @@
159159
"packages/ens-controller/src/EnsController.ts": {
160160
"jsdoc/check-tag-names": 6
161161
},
162-
"packages/eth-block-tracker/src/BlockTracker.ts": {
163-
"@typescript-eslint/naming-convention": 1
164-
},
165162
"packages/eth-block-tracker/src/PollingBlockTracker.test.ts": {
166-
"@typescript-eslint/naming-convention": 1,
167163
"@typescript-eslint/unbound-method": 4
168164
},
169165
"packages/eth-block-tracker/src/PollingBlockTracker.ts": {
170-
"@typescript-eslint/naming-convention": 1,
171166
"@typescript-eslint/prefer-nullish-coalescing": 6,
172167
"@typescript-eslint/unbound-method": 5,
173168
"no-restricted-syntax": 28
@@ -176,7 +171,6 @@
176171
"@typescript-eslint/naming-convention": 1
177172
},
178173
"packages/eth-block-tracker/tests/recordCallsToSetTimeout.ts": {
179-
"@typescript-eslint/naming-convention": 2,
180174
"@typescript-eslint/no-explicit-any": 1
181175
},
182176
"packages/eth-block-tracker/tests/setupAfterEnv.ts": {
@@ -277,7 +271,7 @@
277271
"jsdoc/tag-lines": 4
278272
},
279273
"packages/json-rpc-middleware-stream/src/index.test.ts": {
280-
"@typescript-eslint/prefer-promise-reject-errors": 3,
274+
"@typescript-eslint/prefer-promise-reject-errors": 1,
281275
"no-empty-function": 1
282276
},
283277
"packages/keyring-controller/jest.environment.js": {

‎eslint.config.mjs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ const config = createConfig([
8585
'jest/no-conditional-in-test': 'warn',
8686
'jest/prefer-lowercase-title': 'warn',
8787
'jest/prefer-strict-equal': 'warn',
88+
89+
// TODO: Re-enable this rule
90+
'jest/unbound-method': 'off',
8891
},
8992
settings: {
9093
node: {

‎package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@
5656
"@lavamoat/allow-scripts": "^3.0.4",
5757
"@lavamoat/preinstall-always-fail": "^2.1.0",
5858
"@metamask/create-release-branch": "^4.1.3",
59-
"@metamask/eslint-config": "^14.0.0",
60-
"@metamask/eslint-config-jest": "^14.0.0",
59+
"@metamask/eslint-config": "^14.1.0",
60+
"@metamask/eslint-config-jest": "^14.1.0",
6161
"@metamask/eslint-config-nodejs": "^14.0.0",
62-
"@metamask/eslint-config-typescript": "^14.0.0",
62+
"@metamask/eslint-config-typescript": "^14.1.0",
6363
"@metamask/eth-block-tracker": "^14.0.0",
6464
"@metamask/eth-json-rpc-provider": "^5.0.1",
6565
"@metamask/json-rpc-engine": "^10.1.1",

‎yarn.lock‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3065,10 +3065,10 @@ __metadata:
30653065
"@lavamoat/allow-scripts": "npm:^3.0.4"
30663066
"@lavamoat/preinstall-always-fail": "npm:^2.1.0"
30673067
"@metamask/create-release-branch": "npm:^4.1.3"
3068-
"@metamask/eslint-config": "npm:^14.0.0"
3069-
"@metamask/eslint-config-jest": "npm:^14.0.0"
3068+
"@metamask/eslint-config": "npm:^14.1.0"
3069+
"@metamask/eslint-config-jest": "npm:^14.1.0"
30703070
"@metamask/eslint-config-nodejs": "npm:^14.0.0"
3071-
"@metamask/eslint-config-typescript": "npm:^14.0.0"
3071+
"@metamask/eslint-config-typescript": "npm:^14.1.0"
30723072
"@metamask/eth-block-tracker": "npm:^14.0.0"
30733073
"@metamask/eth-json-rpc-provider": "npm:^5.0.1"
30743074
"@metamask/json-rpc-engine": "npm:^10.1.1"
@@ -3322,17 +3322,17 @@ __metadata:
33223322
languageName: unknown
33233323
linkType: soft
33243324

3325-
"@metamask/eslint-config-jest@npm:^14.0.0":
3326-
version: 14.0.0
3327-
resolution: "@metamask/eslint-config-jest@npm:14.0.0"
3325+
"@metamask/eslint-config-jest@npm:^14.1.0":
3326+
version: 14.1.0
3327+
resolution: "@metamask/eslint-config-jest@npm:14.1.0"
33283328
dependencies:
33293329
"@eslint/js": "npm:^9.11.0"
33303330
globals: "npm:^15.9.0"
33313331
peerDependencies:
3332-
"@metamask/eslint-config": ^14.0.0
3332+
"@metamask/eslint-config": ^14.1.0
33333333
eslint: ^9.11.0
33343334
eslint-plugin-jest: ^28.8.3
3335-
checksum: 10/e7c4f14ff8eae8c1311cd1a941217c39bacf249650b1953138a958472af609a8396722e7b1a0c86386d07f92d7570c3e29754335fe4ef8608a9abf03c7aff6fb
3335+
checksum: 10/2c5bd99fb4470206b47360566f1681c93ed2254080297e2fa34392eb5ae64470138e2f67171a09bb6051e6a4a69eaf430f68b82ef8886604b368cc4129c80462
33363336
languageName: node
33373337
linkType: hard
33383338

@@ -3350,26 +3350,26 @@ __metadata:
33503350
languageName: node
33513351
linkType: hard
33523352

3353-
"@metamask/eslint-config-typescript@npm:^14.0.0":
3354-
version: 14.0.0
3355-
resolution: "@metamask/eslint-config-typescript@npm:14.0.0"
3353+
"@metamask/eslint-config-typescript@npm:^14.1.0":
3354+
version: 14.1.0
3355+
resolution: "@metamask/eslint-config-typescript@npm:14.1.0"
33563356
dependencies:
33573357
"@eslint/js": "npm:^9.11.0"
33583358
peerDependencies:
3359-
"@metamask/eslint-config": ^14.0.0
3359+
"@metamask/eslint-config": ^14.1.0
33603360
eslint: ^9.11.0
33613361
eslint-import-resolver-typescript: ^3.6.3
33623362
eslint-plugin-import-x: ^4.3.0
33633363
eslint-plugin-jsdoc: ^50.2.4
3364-
typescript: ">=4.8.4 <5.6"
3365-
typescript-eslint: ^8.6.0
3366-
checksum: 10/cbf0a9e8523292d41140f90630863d034301422f16e6a42e5881c3593e83c07d0394787563d3e88fee02aa22042a9ca974363d3f192374e31bb0729c6ca8734e
3364+
typescript: ">=4.8.4 <5.9.0"
3365+
typescript-eslint: ^8.24
3366+
checksum: 10/697b61648969f5f53179b8cf83ffb1aa1dbe5ce9ad4f7f4ed0bc4e436c510f1d28543e764467fd880ccb2579b5810e78eee63f972daa55f1b599844b53ea13ca
33673367
languageName: node
33683368
linkType: hard
33693369

3370-
"@metamask/eslint-config@npm:^14.0.0":
3371-
version: 14.0.0
3372-
resolution: "@metamask/eslint-config@npm:14.0.0"
3370+
"@metamask/eslint-config@npm:^14.1.0":
3371+
version: 14.1.0
3372+
resolution: "@metamask/eslint-config@npm:14.1.0"
33733373
dependencies:
33743374
"@eslint/js": "npm:^9.11.0"
33753375
globals: "npm:^15.9.0"
@@ -3381,7 +3381,7 @@ __metadata:
33813381
eslint-plugin-prettier: ^5.2.1
33823382
eslint-plugin-promise: ^7.1.0
33833383
prettier: ^3.3.3
3384-
checksum: 10/b7ae38bf777e9341b8dfac75e98159fb5d5da7d913af2312b586c82370c84acff68ee78e3b104a3577a971d593c6039bd909c8d7ca41cb7a69ed069871080c8a
3384+
checksum: 10/c6313391ea09130ae7254356069c8c28621d8dac668278291cba4436e95d4d5b8a43e11d7ce98ade96b2e4c7706171eba9c966ce7ba439fe888576bb32930b06
33853385
languageName: node
33863386
linkType: hard
33873387

0 commit comments

Comments
 (0)