Remove obsolete comments

Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>

Author: Gudahtt

packages/chain-agnostic-permission/src/scope/filter.test.ts

@@ -72,7 +72,6 @@ describe('filter', () => {
 
     it('returns supported and unsupported scopes', () => {
       MockAssert.assertScopeSupported.mockImplementation((scopeString) => {
-        // This is okay; we are inside of a mock.
         if (scopeString === 'eip155:1') {
           throw new Error('scope not supported');
         }
@@ -173,11 +172,9 @@ describe('filter', () => {
     it('returns only supported methods', () => {
       MockSupported.isSupportedMethod.mockImplementation(
         (scopeString, method) => {
-          // This is okay; we are inside of a mock.
           if (scopeString === 'eip155:1' && method === 'method1') {
             return false;
           }
-          // This is okay; we are inside of a mock.
           if (scopeString === 'eip155:5' && method === 'methodB') {
             return false;
           }
@@ -258,11 +255,9 @@ describe('filter', () => {
     it('returns only supported notifications', () => {
       MockSupported.isSupportedNotification.mockImplementation(
         (scopeString, notification) => {
-          // This is okay; we are inside of a mock.
           if (scopeString === 'eip155:1' && notification === 'notification1') {
             return false;
           }
-          // This is okay; we are inside of a mock.
           if (scopeString === 'eip155:5' && notification === 'notificationB') {
             return false;
           }

packages/controller-utils/src/create-service-policy.test.ts

@@ -1,5 +1,3 @@
-// We use conditions exclusively in this file.
-
 import { handleWhen } from 'cockatiel';
 import { useFakeTimers } from 'sinon';
 import type { SinonFakeTimers } from 'sinon';

packages/network-controller/src/rpc-service/rpc-service-chain.test.ts

@@ -451,7 +451,6 @@ describe('RpcServiceChain', () => {
         onRetryListener.mock.calls.reduce(
           (memo, call) => {
             const { endpointUrl } = call[0];
-            // There is nothing wrong with this.
             memo[endpointUrl] = (memo[endpointUrl] ?? 0) + 1;
             return memo;
           },
@@ -680,7 +679,6 @@ describe('RpcServiceChain', () => {
         onDegradedListener.mock.calls.reduce(
           (memo: Record<string, number>, call) => {
             const { endpointUrl } = call[0];
-            // There is nothing wrong with this.
             memo[endpointUrl] = (memo[endpointUrl] ?? 0) + 1;
             return memo;
           },

packages/network-controller/src/rpc-service/rpc-service.test.ts

@@ -1,5 +1,3 @@
-// We use conditions exclusively in this file.
-
 import { HttpError } from '@metamask/controller-utils';
 import { errorCodes } from '@metamask/rpc-errors';
 import deepFreeze from 'deep-freeze-strict';

packages/network-controller/tests/NetworkController.test.ts

@@ -1,5 +1,3 @@
-// A lot of the tests in this file have conditionals.
-
 import { deriveStateFromMetadata } from '@metamask/base-controller';
 import {
   BuiltInNetworkName,

packages/network-controller/tests/network-client/block-hash-in-response.ts

@@ -326,7 +326,6 @@ export function testsForRpcMethodsThatCheckForBlockHashInResponse(
         },
       );
 
-      // This is not ideal, but we can refactor this later.
       if (providerType === NetworkClientType.Infura) {
         // This is not ideal, but we can refactor this later.
         // eslint-disable-next-line jest/no-conditional-expect

packages/network-controller/tests/network-client/block-param.ts

@@ -403,7 +403,6 @@ export function testsForRpcMethodSupportingBlockParam(
           },
         );
 
-        // This is not ideal, but we can refactor this later.
         if (providerType === NetworkClientType.Infura) {
           // This is not ideal, but we can refactor this later.
           // eslint-disable-next-line jest/no-conditional-expect

packages/network-controller/tests/network-client/no-block-param.ts

@@ -282,7 +282,6 @@ export function testsForRpcMethodAssumingNoBlockParam(
         },
       );
 
-      // This is not ideal, but we can refactor this later.
       if (providerType === NetworkClientType.Infura) {
         // This is not ideal, but we can refactor this later.
         // eslint-disable-next-line jest/no-conditional-expect

packages/network-controller/tests/network-client/rpc-failover.ts

@@ -56,7 +56,6 @@ export function testsForRpcFailoverBehavior({
             const request = requestToCall;
             const requestToMock = getRequestToMock(request, blockNumber);
             const additionalMockRpcCallOptions =
-              // This condition is intentional.
               failure instanceof Error || typeof failure === 'string'
                 ? { error: failure }
                 : { response: failure };
@@ -134,7 +133,6 @@ export function testsForRpcFailoverBehavior({
             const request = requestToCall;
             const requestToMock = getRequestToMock(request, blockNumber);
             const additionalMockRpcCallOptions =
-              // This condition is intentional.
               failure instanceof Error || typeof failure === 'string'
                 ? { error: failure }
                 : { response: failure };
@@ -224,7 +222,6 @@ export function testsForRpcFailoverBehavior({
             const request = requestToCall;
             const requestToMock = getRequestToMock(request, blockNumber);
             const additionalMockRpcCallOptions =
-              // This condition is intentional.
               failure instanceof Error || typeof failure === 'string'
                 ? { error: failure }
                 : { response: failure };
@@ -308,7 +305,6 @@ export function testsForRpcFailoverBehavior({
     it('allows RPC service options to be customized', async () => {
       const customMaxConsecutiveFailures = 6;
       const customMaxRetries = 2;
-      // This is okay.
       const customNumRequestsToMake = isRetriableFailure
         ? customMaxConsecutiveFailures / (customMaxRetries + 1)
         : customMaxConsecutiveFailures;
@@ -333,7 +329,6 @@ export function testsForRpcFailoverBehavior({
               const request = requestToCall;
               const requestToMock = getRequestToMock(request, blockNumber);
               const additionalMockRpcCallOptions =
-                // This condition is intentional.
                 failure instanceof Error || typeof failure === 'string'
                   ? { error: failure }
                   : { response: failure };
@@ -366,7 +361,6 @@ export function testsForRpcFailoverBehavior({
                   messenger,
                   getRpcServiceOptions: (rpcEndpointUrl) => {
                     const commonOptions = { fetch, btoa };
-                    // We need to return different results.
                     if (rpcEndpointUrl === 'https://failover.endpoint') {
                       const headers: HeadersInit = {
                         'X-Baz': 'Qux',