Skip to content

When hasAudio is set to true on configuration, passing at least one audio sample becomes mandatory and maybe shouldn't #51

@GregOriol

Description

@GregOriol

When MovieRecorder's Configuration is set up with hasAudio: true, the internal recorded waits for both a sample of video and audio to actually do the processing

guard self.videoInputs.count == self.configuration.numberOfVideoTracks && self.audioInputs.count == self.configuration.numberOfAudioTracks else {
    return
}

So any buffer sent before both one image and one audio have been provided is discarded.

Maybe it shouldn't?

Also, there is no explicit information on that situation, so if one doesn't provide any audio sample (while testing stuff for example), the asset writer ends up in an "unknown" state when trying to complete the recording, and it's not clear why/what happened.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions