Fix: View widget passing click events and rendering dropdown and tooltips outside the view #5892
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tips outside the view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Prevented click events from propagating to widgets that are not visible (scrolled out of view).
Added culling logic to WWidget and WContainer. This fixes tooltips appearing for off-screen widgets and improves performance by skipping render logic for invisible elements (also fixes Dropdowns rendering outside the view).
Related issues
Couldn't find any.
How Has This Been Tested?
Before: https://ctrlv.tv/7rDZ
After: https://ctrlv.tv/z8sj
Checklist: