-
Notifications
You must be signed in to change notification settings - Fork 87
Add remarks for REMOVEFILTERS #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Explaining behavior for column arguments
|
@cwebe135 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 737cc96: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
|
||
| - If multiple columns are specified, they must be from the same column. | ||
|
|
||
| - If a single solumn is specified, and the target column is sorted by another column, both columns must be included as arguments. This is because DAX includes both columns in the underlying query, so the inclusion of the sort by column adds the filters back in, as described in [this article](https://www.sqlbi.com/blog/marco/2018/05/04/removing-column-filter-in-power-bi-when-sort-by-column-is-active/) on :::no-loc text="sql.bi.com":::. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of links to sqlbi. We should document this ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. That article refers specifically to ALL. Should I add a synopsis to the ALL page and refer to it here, or explain the behavior in both places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeroenterheerdt Should the adjustments to documentation ("we should document this ourselves") be done now or in a later PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't accept links to SQLBI in our documentation. So it has to be documented in this PR.
Explaining behavior for column arguments