Skin files: fix badly chosen keywords

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3159
Reporter	egmont (@egmontkob)
Mentions	ales.janda@….cz (@kybl)

Inspired by #2920 I started adding comments to default.ini. But it would be better if the names were more self-explanatory so we needed fewer comments.

I propose to change at least these names:

gauge -> progressbar (seems people have no clue what gauge could stand for)
reverse -> currentdir (keyword should describe the role, not the look)
[core] disabled -> [dialog] disabled (or "ddisabled" with double d for consistency?), it's only used in dialogs
helpslink -> helpselectedlink

[mc-butler]

Changed by zaytsev (@zyv) on Sep 22, 2016 at 18:43 UTC (comment 1)

• Milestone changed from Future Releases to 4.8.19
• Owner set to andrew_b
• Status changed from new to assigned

[mc-butler]

Changed by egmont (@egmontkob) on Jan 21, 2017 at 9:57 UTC (comment 2)

See #3759 for a few more.

[mc-butler]

Changed by egmont (@egmontkob) on Jan 23, 2017 at 0:43 UTC (comment 3)

Plus:

[editor] -> editbold: just like reverse, the name should describe the role (search result) rather than look.

[editor] -> bookmarkfound: refers to technical implementation rather than user visible role. It's for highlighting search results at "find all". Nowhere does the UI say it has anything to do with bookmarks. It's irrelevant that the source code piggybacks on the same engine.

Some names duplicate the section name (e.g. [editor] -> editstuff, [menu] -> menuwhatever), some others don't (e.g. [diffviewer] -> added). The latter makes more sense to me; if the names are prefixed with the section name then why do we have sections?

[mc-butler]

Changed by zaytsev (@zyv) on Nov 18, 2017 at 17:32 UTC (comment 4)

• Milestone changed from 4.8.20 to 4.8.21

[mc-butler]

Changed by zaytsev (@zyv) on May 27, 2018 at 12:34 UTC (comment 5)

• Milestone changed from 4.8.21 to 4.8.22

[mc-butler]

Changed by zaytsev (@zyv) on Dec 29, 2018 at 14:55 UTC (comment 6)

• Milestone changed from 4.8.22 to 4.8.23

[mc-butler]

Changed by zaytsev (@zyv) on Jun 16, 2019 at 17:23 UTC (comment 7)

• Milestone changed from 4.8.23 to 4.8.24

[mc-butler]

Changed by zaytsev (@zyv) on Jul 5, 2020 at 17:30 UTC (comment 8)

• Milestone changed from 4.8.25 to 4.8.26

[mc-butler]

Changed by kybl (@kybl) on Jul 5, 2020 at 20:23 UTC (comment 9)

• Cc set to ales.janda@….cz

[mc-butler]

Changed by zaytsev (@zyv) on Jan 10, 2021 at 14:23 UTC (comment 10)

• Milestone changed from 4.8.26 to 4.8.27

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 8, 2021 at 6:22 UTC (comment 11)

• Milestone changed from 4.8.27 to Future Releases

[egmontkob]

To follow the example of [widget-*].*-char, it would probably improve readability to separate words by dashes. E.g. inputunchaged -> input-unchaged, commandhistory -> command-history, editrightmargin -> right-margin etc.

---

Avoid unnecessary abbreviations. E.g. [core] has selected, marked and markselect, the latter should be marked-selected.

dselnormal -> selected-normal etc.

---

Under [core], the meaning of selected vs. marked is totally confusing, I never know which one is which. Even the Skin Editor, up to very recently, demonstrated two files named selected-file-1 and selected-file-2 which were not selected but marked, according to the skin's file terminology.

I find both words ambiguous. I'd rather use focus(ed) (consistently with dialog buttons and such) and tag(ged), I think both of these words are more obvious, and the Ctrl+T shortcut and the %t placeholder in the cmdline also refer to the terminology of "tagging".