Skip to content

Revise "terminal_default_color" #4950

@egmontkob

Description

@egmontkob

Is there an existing request for this?

  • I have searched the existing issues

Is your feature request related to a problem?

There's an undocumented skin keyword: Under the section [skin] you can have a terminal_default_color.

lib/skin/colors.c goes like

    CORE_DEFAULT_COLOR = mc_skin_color_get ("skin", "terminal_default_color");
    CORE_NORMAL_COLOR = mc_skin_color_get ("core", "_default_");

which is about as error prone as it could be.

Across the source, CORE_DEFAULT_COLOR is used at a couple of places, at some of which presumably it was meant to be CORE_NORMAL_COLOR (i.e. [core] -> _default_) instead.

What is this all about? Can we remove it? Or at least clean it up, not to have a "default" vs. "normal" confusion.

Describe the solution you'd like

.

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: skinTheming support and skin filesprio: lowMinor problem or easily worked around

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions