Skip to content

[JitDiff X64] [EgorBo] Remove a few unsafe bits from System.Private.DataCont ... #1721

@MihuBot

Description

@MihuBot

Job completed in 16 minutes 27 seconds (remote runner delay: 1 minute 37 seconds).

Using arguments: -NoPRLink
Main commit: dotnet/runtime@00d86e3
PR commit: EgorBo/runtime-1@7b728d3

Diffs

Found 85 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45338594
Total bytes of diff: 45338148
Total bytes of delta: -446 (-0.00 % of base)
Total relative delta: -0.41
    diff is an improvement.
    relative diff is an improvement.


Total byte diff includes -199 bytes from reconciling methods
	Base had    4 unique methods,      199 unique bytes
	Diff had    0 unique methods,        0 unique bytes

Top file improvements (bytes):
        -446 : System.Private.DataContractSerialization.dasm (-0.05 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 260 unchanged.

Top method regressions (bytes):
          11 (0.90 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeParse(ptr,int):this (FullOpts)

Top method improvements (bytes):
        -139 (-19.15 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:ToSpan(System.Span`1[char]):this (FullOpts)
         -97 (-17.67 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:TryGetGuid(byte[],int):bool:this (FullOpts)
         -75 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt64(ptr):long:this (FullOpts) (1 base, 0 diff methods)
         -67 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt64(long,ptr):this (FullOpts) (1 base, 0 diff methods)
         -31 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt32(ptr):int:this (FullOpts) (1 base, 0 diff methods)
         -26 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt32(int,ptr):this (FullOpts) (1 base, 0 diff methods)
         -22 (-5.19 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(byte[],int):this (FullOpts)

Top method regressions (percentages):
          11 (0.90 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeParse(ptr,int):this (FullOpts)

Top method improvements (percentages):
         -31 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt32(ptr):int:this (FullOpts) (1 base, 0 diff methods)
         -75 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt64(ptr):long:this (FullOpts) (1 base, 0 diff methods)
         -26 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt32(int,ptr):this (FullOpts) (1 base, 0 diff methods)
         -67 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt64(long,ptr):this (FullOpts) (1 base, 0 diff methods)
        -139 (-19.15 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:ToSpan(System.Span`1[char]):this (FullOpts)
         -97 (-17.67 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:TryGetGuid(byte[],int):bool:this (FullOpts)
         -22 (-5.19 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(byte[],int):this (FullOpts)

8 total methods with Code Size differences (7 improved, 1 regressed), 283738 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions