V2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

sharrlotte merged 115 commits into main from v2

Jan 27, 2026

.github/workflows/gradle.yml

This file was deleted.

.github/workflows/release.yml

-Original file line number
+Diff line change
@@ -0,0 +1,26 @@
+    name: Build and push to DockerHub
+    on:
+       push:
+          branches:
+             - main
+    jobs:
+       build:
+          runs-on: ubuntu-latest
+          steps:
+             - name: Checkout code
+               uses: actions/checkout@v4
+             - name: Set up Docker Buildx
+               uses: docker/setup-buildx-action@v3
+             - name: Login to DockerHub
+               uses: docker/login-action@v3
+               with:
+                  registry: ghcr.io
+                  username: ${{ github.actor }}
+                  password: ${{ secrets.GITHUB_TOKEN }}
+             - name: Build and push Docker image
+               uses: docker/build-push-action@v5
+               with:
+                  context: ./
+                  push: true
+                  tags: ghcr.io/mindustrytool/player-connect-server:latest

.github/workflows/rust-release.yml

-Original file line number
+Diff line change
@@ -0,0 +1,26 @@
+    name: Build and push to DockerHub
+    on:
+       push:
+          branches:
+             - v2
+    jobs:
+       build:
+          runs-on: ubuntu-latest
+          steps:
+             - name: Checkout code
+               uses: actions/checkout@v4
+             - name: Set up Docker Buildx
+               uses: docker/setup-buildx-action@v3
+             - name: Login to DockerHub
+               uses: docker/login-action@v3
+               with:
+                  registry: ghcr.io
+                  username: ${{ github.actor }}
+                  password: ${{ secrets.GITHUB_TOKEN }}
+             - name: Build and push Docker image
+               uses: docker/build-push-action@v5
+               with:
+                  context: ./
+                  push: true
+                  tags: ghcr.io/mindustrytool/player-connect-server-rust:latest

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,3 +4,4 @@ @@
     .project
     build/
     bin/
+    target

.trae/rules/base.md

-Original file line number
+Diff line change
@@ -0,0 +1,115 @@
+. Project & File Structure Rules
+    One responsibility per module
+    Each mod should have a single clear purpose.
+    Avoid “god modules”.
+    Predictable layout
+    src/ main.rs error.rs config.rs
+    Public API at the top
+    pub struct, pub enum, pub fn first
+    Helpers and private impls later
+. Naming Rules (Very Important for AI)
+    Use descriptive names, never single letters ❌ x, tmp, r, v ✅ request, buffer, user_id, packet_type
+    Avoid abbreviations ❌ cfg, mgr, svc ✅ config, manager, service
+    Types > comments
+    Prefer expressive type names over comments
+    Boolean names must answer yes/no
+    is_connected has_permission should_retry
+. Type System Rules
+    Prefer strong types over primitives
+    struct UserId(u64); struct Port(u16);
+    Never use String when an enum fits
+    enum Protocol { Tcp, Udp, }
+    Avoid Option<T> for required data
+    Use constructor validation instead
+    Avoid Vec<u8> without context
+    struct PacketBytes(Vec<u8>);
+. Error Handling Rules
+    Never use unwrap() or expect() in library code
+    OK only in tests or binaries
+    Use a single error enum
+    enum AppError { Io(std::io::Error), InvalidPacket, Timeout, }
+    Errors must be meaningful ❌ Err(AppError::Invalid) ✅ Err(AppError::InvalidPacketHeader)
+    Implement Display for errors
+    AI tools rely on readable messages
+. Function Design Rules
+    Functions should fit on one screen
+    ~20–40 lines max
+    One logical action per function
+    Avoid hidden side effects
+    No silent global mutation
+    Explicit input > implicit state
+    fn encode(packet: &Packet, buffer: &mut BytesMut)
+    Prefer returning values over mutating inputs
+. Ownership & Borrowing Rules
+    Prefer borrowing over cloning
+    fn process(data: &Data)
+    Clone only at API boundaries
+    Avoid complex lifetime annotations
+    If lifetimes get hard, redesign
+    Use Arc<T> only for shared ownership
+    Never “just in case”
+. Async & Concurrency Rules
+    Never block in async code ❌ std::thread::sleep ✅ tokio::time::sleep
+    Name async functions clearly
+    async fn fetch_user()
+    One async runtime
+    Do not mix Tokio + async-std
+    Use channels instead of shared mutable state
+. Run cargo check before committing, and fix all errors

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V2 #3

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!