Summary
Status::CompletedByAdmin is defined in the Status enum but is never used to transition any order in mostrod.
Analysis
In mostro-core
The status is defined in src/order.rs:
pub enum Status {
// ... other variants ...
CompletedByAdmin,
// ...
}
With serialization to "completed-by-admin".
In mostrod
Only two references exist:
-
src/nip33.rs:211 — Handled alongside Success for NIP-33 event tag creation:
Status::Success | Status::CompletedByAdmin => Ok((true, status)),
-
src/db.rs:14 — Listed in EXCLUDED_ORDER_STATUSES for query filtering:
const EXCLUDED_ORDER_STATUSES: &str = "...'completedbyadmin'...";
What's Missing
- No
admin_complete.rs or admin_complete_action function
- No
Action::AdminCompleted or Action::AdminComplete in mostro-core
- No code path that calls
update_order_event(my_keys, Status::CompletedByAdmin, ...)
- No documentation explaining when this status should be used
Currently Used Admin Statuses
| Status |
Action |
Use Case |
CanceledByAdmin |
admin-cancel |
Admin cancels dispute, returns sats to seller |
SettledByAdmin |
admin-settle |
Admin settles dispute, pays sats to buyer |
CompletedByAdmin |
❌ None |
Not implemented |
Questions
- Is this intentional? Was
CompletedByAdmin reserved for a future feature?
- What's the intended use case? How would it differ from
SettledByAdmin?
- Should it be removed? If there's no plan to implement it, removing it would reduce confusion for client developers.
Impact on Clients
Client developers (like mostro-mobile) may implement UI and logic for CompletedByAdmin that will never be triggered, wasting development effort.
Related
Summary
Status::CompletedByAdminis defined in theStatusenum but is never used to transition any order in mostrod.Analysis
In mostro-core
The status is defined in
src/order.rs:With serialization to
"completed-by-admin".In mostrod
Only two references exist:
src/nip33.rs:211— Handled alongsideSuccessfor NIP-33 event tag creation:src/db.rs:14— Listed inEXCLUDED_ORDER_STATUSESfor query filtering:What's Missing
admin_complete.rsoradmin_complete_actionfunctionAction::AdminCompletedorAction::AdminCompletein mostro-coreupdate_order_event(my_keys, Status::CompletedByAdmin, ...)Currently Used Admin Statuses
CanceledByAdminadmin-cancelSettledByAdminadmin-settleCompletedByAdminQuestions
CompletedByAdminreserved for a future feature?SettledByAdmin?Impact on Clients
Client developers (like mostro-mobile) may implement UI and logic for
CompletedByAdminthat will never be triggered, wasting development effort.Related
admin-complete: https://mostro.network/protocol/