Skip to content

Commit 189ca40

Browse files
oliverkleeoliverklee
committed
[TASK] Raise PHPStan to level 7
https://phpstan.org/user-guide/rule-levels
1 parent c7eb1c1 commit 189ca40

File tree

2 files changed

+169
-1
lines changed

2 files changed

+169
-1
lines changed

‎config/phpstan-baseline.neon‎

Lines changed: 168 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,30 @@ parameters:
66
count: 1
77
path: ../src/CSSList/CSSList.php
88

9+
-
10+
message: '#^Only booleans are allowed in an if condition, Sabberworm\\CSS\\CSSList\\CSSListItem\|false given\.$#'
11+
identifier: if.condNotBoolean
12+
count: 1
13+
path: ../src/CSSList/CSSList.php
14+
15+
-
16+
message: '#^Parameter \#1 \$animationName of method Sabberworm\\CSS\\CSSList\\KeyFrame\:\:setAnimationName\(\) expects non\-empty\-string, string given\.$#'
17+
identifier: argument.type
18+
count: 1
19+
path: ../src/CSSList/CSSList.php
20+
921
-
1022
message: '#^Parameter \#2 \$found of class Sabberworm\\CSS\\Parsing\\UnexpectedTokenException constructor expects string, Sabberworm\\CSS\\Value\\CSSFunction\|Sabberworm\\CSS\\Value\\CSSString\|Sabberworm\\CSS\\Value\\LineName\|Sabberworm\\CSS\\Value\\Size\|Sabberworm\\CSS\\Value\\URL given\.$#'
1123
identifier: argument.type
1224
count: 1
1325
path: ../src/CSSList/CSSList.php
1426

27+
-
28+
message: '#^Parameter \#2 \$found of class Sabberworm\\CSS\\Parsing\\UnexpectedTokenException constructor expects string, Sabberworm\\CSS\\Value\\CSSFunction\|Sabberworm\\CSS\\Value\\LineName\|Sabberworm\\CSS\\Value\\Size\|string given\.$#'
29+
identifier: argument.type
30+
count: 1
31+
path: ../src/CSSList/CSSList.php
32+
1533
-
1634
message: '#^Parameters should have "Sabberworm\\CSS\\CSSList\\CSSListItem\|array" types as the only types passed to this method$#'
1735
identifier: typePerfect.narrowPublicClassMethodParamType
@@ -24,18 +42,72 @@ parameters:
2442
count: 1
2543
path: ../src/CSSList/Document.php
2644

45+
-
46+
message: '#^Method Sabberworm\\CSS\\Parsing\\ParserState\:\:parseIdentifier\(\) should return non\-empty\-string but returns string\.$#'
47+
identifier: return.type
48+
count: 1
49+
path: ../src/Parsing/ParserState.php
50+
51+
-
52+
message: '#^Method Sabberworm\\CSS\\Parsing\\ParserState\:\:strlen\(\) should return int\<0, max\> but returns int\<0, max\>\|false\.$#'
53+
identifier: return.type
54+
count: 1
55+
path: ../src/Parsing/ParserState.php
56+
2757
-
2858
message: '#^Negated boolean expression is always true\.$#'
2959
identifier: booleanNot.alwaysTrue
3060
count: 1
3161
path: ../src/Parsing/ParserState.php
3262

63+
-
64+
message: '#^Property Sabberworm\\CSS\\Parsing\\ParserState\:\:\$currentPosition \(int\<0, max\>\) does not accept int\.$#'
65+
identifier: assign.propertyType
66+
count: 2
67+
path: ../src/Parsing/ParserState.php
68+
69+
-
70+
message: '#^Parameter \#1 \$separator of class Sabberworm\\CSS\\Value\\RuleValueList constructor expects non\-empty\-string, string given\.$#'
71+
identifier: argument.type
72+
count: 1
73+
path: ../src/Rule/Rule.php
74+
75+
-
76+
message: '#^Parameter \#1 \$value of method Sabberworm\\CSS\\Rule\\Rule\:\:setValue\(\) expects Sabberworm\\CSS\\Value\\RuleValueList\|string\|null, Sabberworm\\CSS\\Value\\Value\|string given\.$#'
77+
identifier: argument.type
78+
count: 1
79+
path: ../src/Rule/Rule.php
80+
81+
-
82+
message: '#^Cannot call method getSelector\(\) on Sabberworm\\CSS\\Property\\Selector\|string\.$#'
83+
identifier: method.nonObject
84+
count: 1
85+
path: ../src/RuleSet/DeclarationBlock.php
86+
87+
-
88+
message: '#^Method Sabberworm\\CSS\\RuleSet\\DeclarationBlock\:\:getSelectors\(\) should return array\<Sabberworm\\CSS\\Property\\Selector\> but returns array\<Sabberworm\\CSS\\Property\\Selector\|string\>\.$#'
89+
identifier: return.type
90+
count: 1
91+
path: ../src/RuleSet/DeclarationBlock.php
92+
93+
-
94+
message: '#^Parameter \#1 \$comments of method Sabberworm\\CSS\\RuleSet\\DeclarationBlock\:\:setComments\(\) expects list\<Sabberworm\\CSS\\Comment\\Comment\>, array\<int, Sabberworm\\CSS\\Comment\\Comment\> given\.$#'
95+
identifier: argument.type
96+
count: 1
97+
path: ../src/RuleSet/DeclarationBlock.php
98+
3399
-
34100
message: '#^Parameters should have "string" types as the only types passed to this method$#'
35101
identifier: typePerfect.narrowPublicClassMethodParamType
36102
count: 1
37103
path: ../src/RuleSet/DeclarationBlock.php
38104

105+
-
106+
message: '#^Parameter \#1 \$name of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects non\-empty\-string, string given\.$#'
107+
identifier: argument.type
108+
count: 1
109+
path: ../src/Value/CSSFunction.php
110+
39111
-
40112
message: '#^Parameter \#2 \$arguments of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects array\<Sabberworm\\CSS\\Value\\Value\|string\>\|Sabberworm\\CSS\\Value\\RuleValueList, Sabberworm\\CSS\\Value\\Value\|string given\.$#'
41113
identifier: argument.type
@@ -54,6 +126,24 @@ parameters:
54126
count: 3
55127
path: ../src/Value/Color.php
56128

129+
-
130+
message: '#^Parameter \#1 \$name of method Sabberworm\\CSS\\Value\\CSSFunction\:\:__construct\(\) expects non\-empty\-string, string given\.$#'
131+
identifier: argument.type
132+
count: 1
133+
path: ../src/Value/Color.php
134+
135+
-
136+
message: '#^Parameter \#1 \$name of method Sabberworm\\CSS\\Value\\CSSFunction\:\:setName\(\) expects non\-empty\-string, string given\.$#'
137+
identifier: argument.type
138+
count: 1
139+
path: ../src/Value/Color.php
140+
141+
-
142+
message: '#^Method Sabberworm\\CSS\\Value\\Size\:\:render\(\) should return non\-empty\-string but returns string\.$#'
143+
identifier: return.type
144+
count: 1
145+
path: ../src/Value/Size.php
146+
57147
-
58148
message: '#^Parameters should have "float" types as the only types passed to this method$#'
59149
identifier: typePerfect.narrowPublicClassMethodParamType
@@ -66,6 +156,18 @@ parameters:
66156
count: 1
67157
path: ../src/Value/Size.php
68158

159+
-
160+
message: '#^Method Sabberworm\\CSS\\Value\\Value\:\:parseIdentifierOrFunction\(\) should return Sabberworm\\CSS\\Value\\CSSFunction\|string but returns Sabberworm\\CSS\\Value\\CSSFunction\|Sabberworm\\CSS\\Value\\URL\|string\.$#'
161+
identifier: return.type
162+
count: 1
163+
path: ../src/Value/Value.php
164+
165+
-
166+
message: '#^Parameter \#1 \$name of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects non\-empty\-string, string given\.$#'
167+
identifier: argument.type
168+
count: 1
169+
path: ../src/Value/Value.php
170+
69171
-
70172
message: '#^Parameter \#2 \$arguments of class Sabberworm\\CSS\\Value\\CSSFunction constructor expects array\<Sabberworm\\CSS\\Value\\Value\|string\>\|Sabberworm\\CSS\\Value\\RuleValueList, Sabberworm\\CSS\\Value\\Value\|string given\.$#'
71173
identifier: argument.type
@@ -78,12 +180,36 @@ parameters:
78180
count: 1
79181
path: ../src/Value/Value.php
80182

183+
-
184+
message: '#^Parameter \#1 \$rule of class Sabberworm\\CSS\\Rule\\Rule constructor expects non\-empty\-string, string given\.$#'
185+
identifier: argument.type
186+
count: 1
187+
path: ../tests/Functional/RuleSet/RuleSetTest.php
188+
81189
-
82190
message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertSame\(\) with ''red'' and Sabberworm\\CSS\\Value\\Value will always evaluate to false\.$#'
83191
identifier: staticMethod.impossibleType
84192
count: 1
85193
path: ../tests/ParserTest.php
86194

195+
-
196+
message: '#^Cannot call method getListComponents\(\) on Sabberworm\\CSS\\Value\\RuleValueList\|string\.$#'
197+
identifier: method.nonObject
198+
count: 2
199+
path: ../tests/ParserTest.php
200+
201+
-
202+
message: '#^Cannot call method getListSeparator\(\) on Sabberworm\\CSS\\Value\\RuleValueList\|string\.$#'
203+
identifier: method.nonObject
204+
count: 2
205+
path: ../tests/ParserTest.php
206+
207+
-
208+
message: '#^Cannot call method render\(\) on Sabberworm\\CSS\\Value\\RuleValueList\|string\.$#'
209+
identifier: method.nonObject
210+
count: 1
211+
path: ../tests/ParserTest.php
212+
87213
-
88214
message: '#^Parameter \#1 \$value of method Sabberworm\\CSS\\Rule\\Rule\:\:setValue\(\) expects Sabberworm\\CSS\\Value\\RuleValueList\|string\|null, Sabberworm\\CSS\\Value\\Size given\.$#'
89215
identifier: argument.type
@@ -113,3 +239,45 @@ parameters:
113239
identifier: argument.type
114240
count: 2
115241
path: ../tests/Unit/CSSList/CSSListTest.php
242+
243+
-
244+
message: '#^Method Sabberworm\\CSS\\Tests\\Unit\\Comment\\CommentContainerTest\:\:provideAlternativeNonemptyCommentArray\(\) should return array\<non\-empty\-string, array\{non\-empty\-list\<Sabberworm\\CSS\\Comment\\Comment\>\}\> but returns array\<non\-empty\-string, array\{list\<Sabberworm\\CSS\\Comment\\Comment\>\}\>\.$#'
245+
identifier: return.type
246+
count: 1
247+
path: ../tests/Unit/Comment/CommentContainerTest.php
248+
249+
-
250+
message: '#^Parameter \#1 \$numberOfSpaces of method Sabberworm\\CSS\\OutputFormat\:\:indentWithSpaces\(\) expects int\<1, max\>, int given\.$#'
251+
identifier: argument.type
252+
count: 1
253+
path: ../tests/Unit/OutputFormatTest.php
254+
255+
-
256+
message: '#^Parameter \#1 \$numberOfTabs of method Sabberworm\\CSS\\OutputFormat\:\:indentWithTabs\(\) expects int\<1, max\>, int given\.$#'
257+
identifier: argument.type
258+
count: 1
259+
path: ../tests/Unit/OutputFormatTest.php
260+
261+
-
262+
message: '#^Parameter \#1 \$lineNumber of method Sabberworm\\CSS\\Tests\\Unit\\Position\\Fixtures\\ConcretePosition\:\:setPosition\(\) expects int\<1, max\>\|null, int given\.$#'
263+
identifier: argument.type
264+
count: 2
265+
path: ../tests/Unit/Position/PositionTest.php
266+
267+
-
268+
message: '#^Parameter \#2 \$columnNumber of method Sabberworm\\CSS\\Tests\\Unit\\Position\\Fixtures\\ConcretePosition\:\:setPosition\(\) expects int\<0, max\>\|null, int given\.$#'
269+
identifier: argument.type
270+
count: 3
271+
path: ../tests/Unit/Position/PositionTest.php
272+
273+
-
274+
message: '#^Parameter \#1 \$rule of class Sabberworm\\CSS\\Rule\\Rule constructor expects non\-empty\-string, string given\.$#'
275+
identifier: argument.type
276+
count: 19
277+
path: ../tests/Unit/RuleSet/DeclarationBlockTest.php
278+
279+
-
280+
message: '#^Parameter \#1 \$rule of class Sabberworm\\CSS\\Rule\\Rule constructor expects non\-empty\-string, string given\.$#'
281+
identifier: argument.type
282+
count: 19
283+
path: ../tests/Unit/RuleSet/RuleSetTest.php

‎config/phpstan.neon‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ parameters:
88

99
phpVersion: 70200
1010

11-
level: 6
11+
level: 7
1212

1313
paths:
1414
- %currentWorkingDirectory%/bin/

0 commit comments

Comments
 (0)