Use is_string throughout, not isset

JakeQZ · JakeQZ · commit 1f9fcef118f1 · 2025-07-09T02:14:42.000+01:00
diff --git a/src/RuleSet/DeclarationBlock.php b/src/RuleSet/DeclarationBlock.php
@@ -66,20 +66,20 @@ public static function parse(ParserState $parserState, ?CSSList $list = null): ?
                         }
                         break;
                     case '(':
-                        if (!isset($stringWrapperCharacter)) {
+                        if (!\is_string($stringWrapperCharacter)) {
                             ++$functionNestingLevel;
                         }
                         break;
                     case ')':
-                        if (!isset($stringWrapperCharacter)) {
+                        if (!\is_string($stringWrapperCharacter)) {
                             if ($functionNestingLevel <= 0) {
                                 throw new UnexpectedTokenException('anything but', ')');
                             }
                             --$functionNestingLevel;
                         }
                         break;
                     case ',':
-                        if (!isset($stringWrapperCharacter) && $functionNestingLevel === 0) {
+                        if (!\is_string($stringWrapperCharacter) && $functionNestingLevel === 0) {
                             $selectors[] = \implode('', $selectorParts);
                             $selectorParts = [];
                             $parserState->consume(1);

Original file line number	Diff line number	Diff line change
`@@ -66,20 +66,20 @@ public static function parse(ParserState $parserState, ?CSSList $list = null): ?`
`66`	`66`	`}`
`67`	`67`	`break;`
`68`	`68`	`case '(':`
`69`		`- if (!isset($stringWrapperCharacter)) {`
	`69`	`+ if (!\is_string($stringWrapperCharacter)) {`
`70`	`70`	`++$functionNestingLevel;`
`71`	`71`	`}`
`72`	`72`	`break;`
`73`	`73`	`case ')':`
`74`		`- if (!isset($stringWrapperCharacter)) {`
	`74`	`+ if (!\is_string($stringWrapperCharacter)) {`
`75`	`75`	`if ($functionNestingLevel <= 0) {`
`76`	`76`	`throw new UnexpectedTokenException('anything but', ')');`
`77`	`77`	`}`
`78`	`78`	`--$functionNestingLevel;`
`79`	`79`	`}`
`80`	`80`	`break;`
`81`	`81`	`case ',':`
`82`		`- if (!isset($stringWrapperCharacter) && $functionNestingLevel === 0) {`
	`82`	`+ if (!\is_string($stringWrapperCharacter) && $functionNestingLevel === 0) {`
`83`	`83`	`$selectors[] = \implode('', $selectorParts);`
`84`	`84`	`$selectorParts = [];`
`85`	`85`	`$parserState->consume(1);`