[TASK] Remove getLineNo() (#1258)

Closes #974.

Author: JakeQZ

CHANGELOG.md

@@ -81,6 +81,9 @@ Please also have a look at our
 
 ### Removed
 
+- Remove `getLineNo()` from these classes (use `getLineNumber()` instead):
+  `Comment`, `CSSList`, `SourceException`, `Charset`, `CSSNamespace`, `Import`,
+  `Rule`, `DeclarationBlock`, `RuleSet`, `CSSFunction`, `Value` (#1258)
 - Remove `Rule::getColNo()` (use `getColumnNumber()` instead) (#1287)
 - Passing a string as the first argument to `getAllValues()` is no longer
   supported and will not work;

src/Position/Position.php

@@ -31,14 +31,6 @@ public function getLineNumber(): ?int
         return $this->lineNumber;
     }
 
-    /**
-     * @return int<0, max>
-     */
-    public function getLineNo(): int
-    {
-        return $this->getLineNumber() ?? 0;
-    }
-
     /**
      * @return int<0, max>|null
      */

src/Position/Positionable.php

@@ -16,13 +16,6 @@ interface Positionable
      */
     public function getLineNumber(): ?int;
 
-    /**
-     * @return int<0, max>
-     *
-     * @deprecated in version 8.9.0, will be removed in v9.0. Use `getLineNumber()` instead.
-     */
-    public function getLineNo(): int;
-
     /**
      * @return int<0, max>|null
      */

tests/Unit/CSSList/AtRuleBlockListTest.php

@@ -114,18 +114,6 @@ public function atRuleArgsReturnsArgumentsProvidedToConstructor(): void
         self::assertSame($arguments, $subject->atRuleArgs());
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
-    {
-        $lineNumber = 42;
-
-        $subject = new AtRuleBlockList('', '', $lineNumber);
-
-        self::assertSame($lineNumber, $subject->getLineNo());
-    }
-
     /**
      * @test
      */

tests/Unit/CSSList/CSSListTest.php

@@ -57,28 +57,6 @@ public function implementsCSSListItem(): void
         self::assertInstanceOf(CSSListItem::class, $subject);
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoByDefaultReturnsZero(): void
-    {
-        $subject = new ConcreteCSSList();
-
-        self::assertSame(0, $subject->getLineNo());
-    }
-
-    /**
-     * @test
-     */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
-    {
-        $lineNumber = 42;
-
-        $subject = new ConcreteCSSList($lineNumber);
-
-        self::assertSame($lineNumber, $subject->getLineNo());
-    }
-
     /**
      * @test
      */

tests/Unit/CSSList/KeyFrameTest.php

@@ -68,18 +68,6 @@ public function isCSSList(): void
         self::assertInstanceOf(CSSList::class, $subject);
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
-    {
-        $lineNumber = 42;
-
-        $subject = new KeyFrame($lineNumber);
-
-        self::assertSame($lineNumber, $subject->getLineNo());
-    }
-
     /**
      * @test
      */

tests/Unit/Comment/CommentTest.php

@@ -57,27 +57,6 @@ public function setCommentSetsComments(): void
         self::assertSame($comment, $subject->getComment());
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoOnEmptyInstanceReturnsZero(): void
-    {
-        $subject = new Comment();
-
-        self::assertSame(0, $subject->getLineNo());
-    }
-
-    /**
-     * @test
-     */
-    public function getLineNoInitiallyReturnsLineNumberPassedToConstructor(): void
-    {
-        $lineNumber = 42;
-        $subject = new Comment('', $lineNumber);
-
-        self::assertSame($lineNumber, $subject->getLineNo());
-    }
-
     /**
      * @test
      */

tests/Unit/Parsing/OutputExceptionTest.php

@@ -32,27 +32,6 @@ public function getMessageReturnsMessageProvidedToConstructor(): void
         self::assertStringContainsString($message, $exception->getMessage());
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoByDefaultReturnsZero(): void
-    {
-        $exception = new OutputException('foo');
-
-        self::assertSame(0, $exception->getLineNo());
-    }
-
-    /**
-     * @test
-     */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
-    {
-        $lineNumber = 17;
-        $exception = new OutputException('foo', $lineNumber);
-
-        self::assertSame($lineNumber, $exception->getLineNo());
-    }
-
     /**
      * @test
      */

tests/Unit/Parsing/SourceExceptionTest.php

@@ -23,27 +23,6 @@ public function getMessageReturnsMessageProvidedToConstructor(): void
         self::assertStringContainsString($message, $exception->getMessage());
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoByDefaultReturnsZero(): void
-    {
-        $exception = new SourceException('foo');
-
-        self::assertSame(0, $exception->getLineNo());
-    }
-
-    /**
-     * @test
-     */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
-    {
-        $lineNumber = 17;
-        $exception = new SourceException('foo', $lineNumber);
-
-        self::assertSame($lineNumber, $exception->getLineNo());
-    }
-
     /**
      * @test
      */

tests/Unit/Parsing/UnexpectedEOFExceptionTest.php

@@ -21,27 +21,6 @@ public function extendsUnexpectedTokenException(): void
         self::assertInstanceOf(UnexpectedTokenException::class, new UnexpectedEOFException('expected', 'found'));
     }
 
-    /**
-     * @test
-     */
-    public function getLineNoByDefaultReturnsZero(): void
-    {
-        $exception = new UnexpectedEOFException('expected', 'found');
-
-        self::assertSame(0, $exception->getLineNo());
-    }
-
-    /**
-     * @test
-     */
-    public function getLineNoReturnsLineNumberProvidedToConstructor(): void
-    {
-        $lineNumber = 17;
-        $exception = new UnexpectedEOFException('expected', 'found', 'literal', $lineNumber);
-
-        self::assertSame($lineNumber, $exception->getLineNo());
-    }
-
     /**
      * @test
      */