fixup! [FEATURE] Support for inserting an item in a CSSList

Author: ziegenberg

src/CSSList/CSSList.php

@@ -295,21 +295,18 @@ public function splice($iOffset, $iLength = null, $mReplacement = null)
     }
 
     /**
-     * Insert an item before or after its sibling.
+     * Insert an item before its sibling.
      *
      * @param RuleSet|CSSList|Import|Charset $oItem The item.
      * @param RuleSet|CSSList|Import|Charset $oSibling The sibling.
-     * @param $sPosition The position.
      */
-    public function insert($oItem, $oSibling, string $sPosition = 'before'): void
+    public function insertBefore($oItem, $oSibling): void
     {
         $iIndex = in_array($oSibling, $this->aContents);
         if ($iIndex === false) {
             $this->append($oItem);
-        } elseif ($sPosition === 'before') {
-            $this->replace($oSibling, array($oItem, $oSibling));
         } else {
-            $this->replace($oSibling, array($oSibling, $oItem));
+            $this->replace($oSibling, array($oItem, $oSibling));
         }
     }
 

tests/CSSList/DocumentTest.php

@@ -87,9 +87,9 @@ public function setContentsReplacesContentsSetInPreviousCall(): void
     }
 
     /**
-     * @return Generator
+     * @return \Generator<array<array<DeclarationBlock>, DeclarationBlock, DeclarationBlock, array<DeclarationBlock>>>
      */
-    public static function insertDataProvider(): \Generator
+    public static function insertBeforeDataProvider(): \Generator
     {
 
         $bogusOne = new DeclarationBlock();
@@ -110,21 +110,12 @@ public static function insertDataProvider(): \Generator
             'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
             'oItem' => $oItem,
             'oSibling' => $oSibling,
-            'position' => 'before',
             'expectedContent' => [$bogusOne, $oItem, $oSibling, $bogusTwo],
             ];
-        yield 'insert after' => [
-            'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
-            'oItem' => $oItem,
-            'oSibling' => $oSibling,
-            'position' => 'after',
-            'expectedContent' => [$bogusOne, $oSibling, $oItem, $bogusTwo],
-            ];
         yield 'append if not found' => [
             'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
             'oItem' => $oItem,
             'oSibling' => $oOrphan,
-            'position' => 'before',
             'expectedContent' => [$bogusOne, $oSibling, $bogusTwo, $oItem],
             ];
     }
@@ -138,21 +129,20 @@ public static function insertDataProvider(): \Generator
      * @param $sPosition
      * @param $expectedContent
      *
-     * @dataProvider insertDataProvider
+     * @dataProvider insertBeforeDataProvider
      */
-    public function insertContent(
+    public function insertContentBefore(
         array $initialContent,
         DeclarationBlock $oItem,
         DeclarationBlock $oSibling,
-        string $sPosition,
         array $expectedContent
     ) {
 
         $this->subject->setContents($initialContent);
 
         self::assertCount(3, $this->subject->getContents());
 
-        $this->subject->insert($oItem, $oSibling, $sPosition);
+        $this->subject->insertBefore($oItem, $oSibling);
 
         self::assertCount(4, $this->subject->getContents());
         self::assertSame($expectedContent, $this->subject->getContents());