Skip to content
This repository was archived by the owner on Jan 4, 2021. It is now read-only.

Commit 2e5b477

Browse files
RomainCscnRomainCscn
committed
[DEV] Improve smart guide writing
No more writings from tag icon or actions menu
1 parent 97cfcfc commit 2e5b477

File tree

9 files changed

+11618
-10386
lines changed

9 files changed

+11618
-10386
lines changed

‎dist/myscript.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/myscript.min.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/ast/source/grabber/PointerEventGrabber.js.json‎

Lines changed: 11598 additions & 10372 deletions
Large diffs are not rendered by default.

‎docs/coverage.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
"expectCount": 2,
8484
"actualCount": 1,
8585
"undocumentLines": [
86-
186
86+
189
8787
]
8888
},
8989
"src/recognizer/rest/v3/Cdkv3RestTextRecognizer.js": {

‎docs/dump.json‎

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

‎docs/file/src/grabber/PointerEventGrabber.js.html‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,9 @@
398398
evt.stopPropagation();
399399
editor.pointerDown(extractPoint(evt, element, editor.configuration, offsetTop, offsetLeft), evt.pointerType, pointerId);
400400
}
401+
} else if (evt.target.id === 'ellipsis' || evt.target.id === 'tag-icon') {
402+
hideMenu(evt);
403+
hideCandidates(evt);
401404
} else { // FIXME add more complete verification to pointer down on smartguide
402405
hideMenu(evt);
403406
hideCandidates(evt);

‎docs/function/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8049,11 +8049,11 @@ <h3 data-ice="anchor" id="static-function-detach">
80498049
<span class="right-info">
80508050

80518051

8052-
<span data-ice="source"><span><a href="file/src/grabber/PointerEventGrabber.js.html#lineNumber186">source</a></span></span>
8052+
<span data-ice="source"><span><a href="file/src/grabber/PointerEventGrabber.js.html#lineNumber189">source</a></span></span>
80538053
</span>
80548054
</h3>
80558055

8056-
<div data-ice="importPath" class="import-path"><pre class="prettyprint"><code data-ice="importPathCode">import {detach} from &apos;<span><a href="file/src/grabber/PointerEventGrabber.js.html#lineNumber186">myscript/src/grabber/PointerEventGrabber.js</a></span>&apos;</code></pre></div>
8056+
<div data-ice="importPath" class="import-path"><pre class="prettyprint"><code data-ice="importPathCode">import {detach} from &apos;<span><a href="file/src/grabber/PointerEventGrabber.js.html#lineNumber189">myscript/src/grabber/PointerEventGrabber.js</a></span>&apos;</code></pre></div>
80578057

80588058

80598059

‎docs/source.html‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@
308308
<td class="coverage"><span data-ice="coverage">89 %</span><span data-ice="coverageCount" class="coverage-count">51/57</span></td>
309309
<td style="display: none;" data-ice="size">28557 byte</td>
310310
<td style="display: none;" data-ice="lines">952</td>
311-
<td style="display: none;" data-ice="updated">2018-01-05 16:41:05 (UTC)</td>
311+
<td style="display: none;" data-ice="updated">2018-01-05 17:04:09 (UTC)</td>
312312
</tr>
313313
<tr data-ice="file">
314314
<td data-ice="filePath"><span><a href="file/src/EditorFacade.js.html">src/EditorFacade.js</a></span></td>
@@ -401,13 +401,13 @@
401401
<td style="display: none;" data-ice="updated">2018-01-03 14:51:01 (UTC)</td>
402402
</tr>
403403
<tr data-ice="file">
404-
<td data-ice="filePath"><span><a href="file/src/grabber/PointerEventGrabber.js.html#errorLines=186">src/grabber/PointerEventGrabber.js</a></span></td>
404+
<td data-ice="filePath"><span><a href="file/src/grabber/PointerEventGrabber.js.html#errorLines=189">src/grabber/PointerEventGrabber.js</a></span></td>
405405
<td data-ice="identifier" class="identifiers"><span><a href="function/index.html#static-function-attach">attach</a></span>
406406
<span><a href="function/index.html#static-function-detach">detach</a></span></td>
407407
<td class="coverage"><span data-ice="coverage">50 %</span><span data-ice="coverageCount" class="coverage-count">1/2</span></td>
408-
<td style="display: none;" data-ice="size">8665 byte</td>
409-
<td style="display: none;" data-ice="lines">191</td>
410-
<td style="display: none;" data-ice="updated">2018-01-03 14:51:01 (UTC)</td>
408+
<td style="display: none;" data-ice="size">8792 byte</td>
409+
<td style="display: none;" data-ice="lines">194</td>
410+
<td style="display: none;" data-ice="updated">2018-01-06 08:56:11 (UTC)</td>
411411
</tr>
412412
<tr data-ice="file">
413413
<td data-ice="filePath"><span><a href="file/src/model/InkModel.js.html">src/model/InkModel.js</a></span></td>
@@ -447,7 +447,7 @@
447447
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">8/8</span></td>
448448
<td style="display: none;" data-ice="size">4561 byte</td>
449449
<td style="display: none;" data-ice="lines">140</td>
450-
<td style="display: none;" data-ice="updated">2018-01-05 16:23:11 (UTC)</td>
450+
<td style="display: none;" data-ice="updated">2018-01-05 17:04:09 (UTC)</td>
451451
</tr>
452452
<tr data-ice="file">
453453
<td data-ice="filePath"><span><a href="file/src/model/StrokeComponent.js.html">src/model/StrokeComponent.js</a></span></td>
@@ -685,7 +685,7 @@
685685
<td class="coverage"><span data-ice="coverage">100 %</span><span data-ice="coverageCount" class="coverage-count">1/1</span></td>
686686
<td style="display: none;" data-ice="size">7038 byte</td>
687687
<td style="display: none;" data-ice="lines">153</td>
688-
<td style="display: none;" data-ice="updated">2018-01-05 16:23:11 (UTC)</td>
688+
<td style="display: none;" data-ice="updated">2018-01-05 17:04:09 (UTC)</td>
689689
</tr>
690690
<tr data-ice="file">
691691
<td data-ice="filePath"><span><a href="file/src/recognizer/websocket/v4/Cdkv4WSIInkRecognizer.js.html#errorLines=204,211,218,57,68,80,89,98">src/recognizer/websocket/v4/Cdkv4WSIInkRecognizer.js</a></span></td>

‎src/grabber/PointerEventGrabber.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ export function attach(element, editor, offsetTop = 0, offsetLeft = 0) {
108108
evt.stopPropagation();
109109
editor.pointerDown(extractPoint(evt, element, editor.configuration, offsetTop, offsetLeft), evt.pointerType, pointerId);
110110
}
111+
} else if (evt.target.id === 'ellipsis' || evt.target.id === 'tag-icon') {
112+
hideMenu(evt);
113+
hideCandidates(evt);
111114
} else { // FIXME add more complete verification to pointer down on smartguide
112115
hideMenu(evt);
113116
hideCandidates(evt);

0 commit comments

Comments
 (0)