From 3abdd7e1a356fbd36e12219beca48d098cc2932f Mon Sep 17 00:00:00 2001 From: Joy Wang <108701016+joyqvq@users.noreply.github.com> Date: Tue, 3 Mar 2026 10:48:00 -0500 Subject: [PATCH] [seal] update default for verifyKeyServers to false --- .changeset/shaky-aliens-kiss.md | 5 +++++ packages/seal/src/client.ts | 2 +- packages/seal/src/types.ts | 12 ++++++++++-- 3 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 .changeset/shaky-aliens-kiss.md diff --git a/.changeset/shaky-aliens-kiss.md b/.changeset/shaky-aliens-kiss.md new file mode 100644 index 000000000..3f442d433 --- /dev/null +++ b/.changeset/shaky-aliens-kiss.md @@ -0,0 +1,5 @@ +--- +'@mysten/seal': minor +--- + +[seal] Update default for verifyKeyServers to false diff --git a/packages/seal/src/client.ts b/packages/seal/src/client.ts index d5af830c0..bf3cc3706 100644 --- a/packages/seal/src/client.ts +++ b/packages/seal/src/client.ts @@ -82,7 +82,7 @@ export class SealClient { .map((server) => server.weight) .reduce((sum, term) => sum + term, 0); - this.#verifyKeyServers = options.verifyKeyServers ?? true; + this.#verifyKeyServers = options.verifyKeyServers ?? false; this.#timeout = options.timeout ?? 10_000; } diff --git a/packages/seal/src/types.ts b/packages/seal/src/types.ts index c281980b6..2fbd8781f 100644 --- a/packages/seal/src/types.ts +++ b/packages/seal/src/types.ts @@ -13,7 +13,11 @@ export type SealCompatibleClient = ClientWithExtensions<{ export interface SealOptions { /** Array of key server configs consisting of objectId, weight, optional API key name and API key */ serverConfigs: KeyServerConfig[]; - /** Whether to verify the key servers' authenticity. */ + /** + * Whether to verify the key servers' authenticity. + * Note: /service verification is skipped for committee key servers (serverType === 'Committee') + * since their requests go through an aggregator. + */ verifyKeyServers?: boolean; /** Timeout in milliseconds for network requests. */ timeout?: number; @@ -36,7 +40,11 @@ export interface SealClientOptions { suiClient: SealCompatibleClient; /** Array of key server configs consisting of objectId, weight, optional API key name and API key */ serverConfigs: KeyServerConfig[]; - /** Whether to verify the key servers' authenticity. */ + /** + * Whether to verify the key servers' authenticity. + * Note: /service verification is skipped for committee key servers (serverType === 'Committee') + * since their requests go through an aggregator. + */ verifyKeyServers?: boolean; /** Timeout in milliseconds for network requests. */ timeout?: number;