mythtv/libs/libmythui/mediamonitor-unix.cpp: no <fstab.h> for musl, please use <mntent.h> instead

[clan]

• Platform:
  Gentoo Linux w/ musl profile

• MythTV version:

fixes/35

• Package version:

• Component:

What steps will reproduce the bug?

build with musl is failed with following error:

mediamonitor-unix.cpp:11:10: fatal error: 'fstab.h' file not found

How often does it reproduce? Is there a required condition?

What is the expected behaviour?

What do you see instead?

Additional information

fstab.h is not exist in musl, maybe use mntent.h instead?

[linuxdude42]

Does that change work for you? Where does it get the value for _PATH_FS, or the definitions for 'struct fstab', getfsent(), and setfsent(). Those are all defined in fstab.h on my system. It seems like a better approach would be to skip all fstab related code when fstab.h can't be found, like for android compiles.

[clan]

which change? glibc have fstab.h and getfsent, but musl has no fstab.h, so the build is failed.
I haven't find time to replace them with mntent.h and getfsent etc. yet.

[linuxdude42]

Try pulling the latest update and compiling again. This should be fixed.

[clan]

build success after apply following patch to fix error below:

mmulticastsocketdevice.h:54:68: error: 'u_char' has not been declared; did you mean 'uchar'?

mythtv/libs/libmythupnp/mmulticastsocketdevice.h is removed in master branch.

diff --git a/libs/libmythupnp/mmulticastsocketdevice.h b/libs/libmythupnp/mmulticastsocketdevice.h
index 75b3c82..65ea84a 100644
--- a/libs/libmythupnp/mmulticastsocketdevice.h
+++ b/libs/libmythupnp/mmulticastsocketdevice.h
@@ -15,6 +15,8 @@

 #ifdef __FreeBSD__
 #  include <sys/types.h>
+#elif defined(__linux__)
+#  include <sys/types.h>
 #endif

 #ifdef _WIN32