Fails on make libs at libbluray-1.1.2

[sgreene820]

Attempting to build the android client, 0.33. It fails on building libbluray-1.1.2 without giving a meaningful hint (that I can see).

libtool: compile: /home/sgreene/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi29-clang -DHAVE_CONFIG_H -I. -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200809L -D_REENTRANT -I./src -I./src/libbluray -I./src/libbluray -I/home/sgreene/MythAndroid/packaging/android/libs/libbluray-1.1.2/jni -I/home/sgreene/MythAndroid/packaging/android/libs/libbluray-1.1.2/jni/linux -I./contrib/libudfread/src/ -I/home/sgreene/MythAndroid/packaging/android/libsinstall/include/libxml2 -I/home/sgreene/MythAndroid/packaging/android/libsinstall/include/freetype2 -std=c99 -isysroot /home/sgreene/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -isystem /home/sgreene/MythAndroid/packaging/android/libsinstall/include -D__ANDROID_API__=29 -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wshadow -Werror=implicit-function-declaration -Wextra -Winline -O3 -fomit-frame-pointer -MT contrib/libudfread/src/libbluray_la-udfread.lo -MD -MP -MF contrib/libudfread/src/.deps/libbluray_la-udfread.Tpo -c contrib/libudfread/src/udfread.c -o contrib/libudfread/src/libbluray_la-udfread.o >/dev/null 2>&1
mv -f src/libbluray/hdmv/.deps/libbluray_la-hdmv_vm.Tpo src/libbluray/hdmv/.deps/libbluray_la-hdmv_vm.Plo
mv -f src/libbluray/decoders/.deps/libbluray_la-graphics_controller.Tpo src/libbluray/decoders/.deps/libbluray_la-graphics_controller.Plo
mv -f contrib/libudfread/src/.deps/libbluray_la-udfread.Tpo contrib/libudfread/src/.deps/libbluray_la-udfread.Plo
mv -f src/libbluray/.deps/libbluray_la-bluray.Tpo src/libbluray/.deps/libbluray_la-bluray.Plo
make[2]: Leaving directory '/home/sgreene/MythAndroid/packaging/android/libs/libbluray-1.1.2'
make[1]: *** [Makefile:1032: all] Error 2
make[1]: Leaving directory '/home/sgreene/MythAndroid/packaging/android/libs/libbluray-1.1.2'
~/MythAndroid/packaging/android/libs ~/MythAndroid/packaging/android
make: *** [Makefile:53: libs] Error 2

[nietu]

Had you find solution for this? I had same issue when trying to build mythtv for Nvidia shield android.
In my setup, issue is in javac version. I had tested build w/ openjdk javac 11, 13

in 11 it failed due this:

/src/libbluray/bdj/java-j2se/java/io/BDFileSystemImpl.java:21: error: BDFileSystemImpl is not abstract and does not override abstract method isInvalid(File) in FileSystem
    [javac] class BDFileSystemImpl extends BDFileSystem {
    [javac] ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
    [javac] 4 warnings

BUILD FAILED
/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/src/libbluray/bdj/build.xml:32: Compile failed; see the compiler error output for details.

in 13 it failed due this:

libtool: compile:  /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android29-clang -DHAVE_CONFIG_H -I. -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200809L -D_REENTRANT -I./src -I./src/libbluray -I./src/libbluray -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni/linux -I./contrib/libudfread/src/ -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/libxml2 -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/freetype2 -std=c99 -isysroot /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -isystem /home/nietu/projects/mythtv/packaging/android/libsinstall64/include -D__ANDROID_API__=29 -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wshadow -Werror=implicit-function-declaration -Wextra -Winline -O3 -fomit-frame-pointer -MT src/libbluray/bd    [javac] warning: [options] bootstrap class path not set in conjunction with -source 6
j/native/libbluray_la-org_videolan_Logger.lo -MD -MP -MF src/libbluray/bdj/native/.deps/libbluray_la-org_videolan_Logger.Tpo -c src/libbluray/bdj/native/org_videolan_Logger.c  -fPIC -DPIC -o src/libbluray/bdj/native/.libs/libbluray_la-org_videolan_Logger.o
    [javac] error: Source option 6 is no longer supported. Use 7 or later.
    [javac] error: Target option 6 is no longer supported. Use 7 or later.
libtool: compile:  /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android29-clang -DHAVE_CONFIG_H -I. -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200809L -D_REENTRANT -I./src -I./src/libbluray -I./src/libbluray -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni/linux -I./contrib/libudfread/src/ -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/libxml2 -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/freetype2 -std=c99 -isysroot /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -isystem /home/nietu/projects/mythtv/packaging/android/libsinstall64/include -D__ANDROID_API__=29 -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wshadow -Werror=implicit-function-declaration -Wextra -Winline -O3 -fomit-frame-pointer -MT src/libbluray/bdj/native/libbluray_la-register_native.lo -MD -MP -MF src/libbluray/bdj/native/.deps/libbluray_la-register_native.Tpo -c src/libbluray/bdj/native/register_native.c  -fPIC -DPIC -o src/libbluray/bdj/native/.libs/libbluray_la-register_native.o

BUILD FAILED
/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/src/libbluray/bdj/build.xml:26: Compile failed; see the compiler error output for details.```

[jpoet]

The last time I tried to build for Android, I used the attached patch to get past that part. It pulls the latest version of libbluray which then seems to build.

android-libbluray-master.txt

[sgreene820]

Is that patch to be run from "packaging/android"? I'd like to give it a try. Steve

…

On Sat, Dec 30, 2023 at 12:19 PM John Poet ***@***.***> wrote: The last time I tried to build for Android, I used the attached patch to get past that part. It pulls the latest version of libbluray which then seems to build. android-libbluray-master.txt <https://github.com/MythTV/packaging/files/13798756/android-libbluray-master.txt> — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASQW2SZKJC27E6Q24UILYDDYMBELXAVCNFSM6AAAAAAX3MF7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGU3DQNRUGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[sgreene820]

@nietu, that's the same error I got when I ran the makefile in the libbluray sub-dir. I'm going to try the patch provided above. Steve

…

On Sat, Dec 30, 2023 at 8:47 AM nietu ***@***.***> wrote: Had you find solution for this? I had same issue when trying to build mythtv for Nvidia shield android. In my setup, issue is in javac version. I had tested build w/ openjdk javac 11, 13 *in 11 it failed due this:* /src/libbluray/bdj/java-j2se/java/io/BDFileSystemImpl.java:21: error: BDFileSystemImpl is not abstract and does not override abstract method isInvalid(File) in FileSystem [javac] class BDFileSystemImpl extends BDFileSystem { [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 1 error [javac] 4 warnings BUILD FAILED /home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/src/libbluray/bdj/build.xml:32: Compile failed; see the compiler error output for details. *in 13 it failed due this:* libtool: compile: /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android29-clang -DHAVE_CONFIG_H -I. -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200809L -D_REENTRANT -I./src -I./src/libbluray -I./src/libbluray -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni/linux -I./contrib/libudfread/src/ -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/libxml2 -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/freetype2 -std=c99 -isysroot /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -isystem /home/nietu/projects/mythtv/packaging/android/libsinstall64/include -D__ANDROID_API__=29 -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wshadow -Werror=implicit-function-declaration -Wextra -Winline -O3 -fomit-frame-pointer -MT src/libbluray/bd [javac] warning: [options] bootstrap class path not set in conjunction with -source 6 j/native/libbluray_la-org_videolan_Logger.lo -MD -MP -MF src/libbluray/bdj/native/.deps/libbluray_la-org_videolan_Logger.Tpo -c src/libbluray/bdj/native/org_videolan_Logger.c -fPIC -DPIC -o src/libbluray/bdj/native/.libs/libbluray_la-org_videolan_Logger.o [javac] error: Source option 6 is no longer supported. Use 7 or later. [javac] error: Target option 6 is no longer supported. Use 7 or later. libtool: compile: /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android29-clang -DHAVE_CONFIG_H -I. -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200809L -D_REENTRANT -I./src -I./src/libbluray -I./src/libbluray -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni -I/home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/jni/linux -I./contrib/libudfread/src/ -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/libxml2 -I/home/nietu/projects/mythtv/packaging/android/libsinstall64/include/freetype2 -std=c99 -isysroot /home/nietu/Android/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -isystem /home/nietu/projects/mythtv/packaging/android/libsinstall64/include -D__ANDROID_API__=29 -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wcast-qual -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wshadow -Werror=implicit-function-declaration -Wextra -Winline -O3 -fomit-frame-pointer -MT src/libbluray/bdj/native/libbluray_la-register_native.lo -MD -MP -MF src/libbluray/bdj/native/.deps/libbluray_la-register_native.Tpo -c src/libbluray/bdj/native/register_native.c -fPIC -DPIC -o src/libbluray/bdj/native/.libs/libbluray_la-register_native.o BUILD FAILED /home/nietu/projects/mythtv/packaging/android/libs64/libbluray-1.1.2/src/libbluray/bdj/build.xml:26: Compile failed; see the compiler error output for details.``` — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASQW2S2CUOXDLS33APPT773YMALQBAVCNFSM6AAAAAAX3MF7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGUZTCNBQGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jpoet]

Is that patch to be run from "packaging/android"? I'd like to give it a try. Steve
…
On Sat, Dec 30, 2023 at 12:19 PM John Poet @.> wrote: The last time I tried to build for Android, I used the attached patch to get past that part. It pulls the latest version of libbluray which then seems to build. android-libbluray-master.txt https://github.com/MythTV/packaging/files/13798756/android-libbluray-master.txt — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASQW2SZKJC27E6Q24UILYDDYMBELXAVCNFSM6AAAAAAX3MF7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGU3DQNRUGQ . You are receiving this because you authored the thread.Message ID: @.>

I believe it was to be applied just outside of the android directory, or inside the android directory if you use "-p1", but that is from memory. I don't currently have the code in place to test. You could try various values to patch -p# < patchfile until it applies.

[nietu]

@jpoet Thx that pach fix the issue
@sgreene820 run in root of mythtv/packaging repo
$ patch -p1 < android-libbluray-master.txt

[sgreene820]

Still fails here.

`compile:
[javac] /home/sgreene/MythAndroid/packaging/android/libs/libbluray/src/libbluray/bdj/build.xml:26: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
[javac] Compiling 33 source files to /home/sgreene/MythAndroid/packaging/android/libs/libbluray/src/libbluray/bdj/build
[javac] warning: [options] bootstrap class path not set in conjunction with -source 5
[javac] error: Source option 5 is no longer supported. Use 6 or later.
[javac] error: Target option 1.5 is no longer supported. Use 1.6 or later.

BUILD FAILED
/home/sgreene/MythAndroid/packaging/android/libs/libbluray/src/libbluray/bdj/build.xml:26: Compile failed; see the compiler error output for details.

Total time: 0 seconds
make[1]: *** [Makefile:2902: all-local] Error 1
make[1]: Leaving directory '/home/sgreene/MythAndroid/packaging/android/libs/libbluray'
make: *** [Makefile:1055: all] Error 2`

[nietu]

@sgreene820 I did overcome this issue

[javac] error: Source option 5 is no longer supported. Use 6 or later.
[javac] error: Target option 1.5 is no longer supported. Use 1.6 or later.

by using openjdk version 11 in ubuntu. Any more fresh java version failed

[sgreene820]

I'll try that tomorrow. Thanks for the suggestion.

[sgreene820]

@nietu, I got a little further this time. Now it's looking for src/files not found. Are these in libbluray-dev? clang: error: no such file or directory:

'src/file/.libs/libbluray_la-file.o' clang: error: no such file or directory: 'src/file/.libs/libbluray_la-filesystem.o' clang: error: no such file or directory: 'src/libbluray/.libs/libbluray_la-register.o' clang: error: no such file or directory: 'src/libbluray/bdnav/.libs/libbluray_la-bdid_parse.o' clang: error: no such file or directory: 'src/libbluray/bdnav/.libs/libbluray_la-bdmv_parse.o' clang: error: no such file or directory: 'src/libbluray/bdnav/.libs/libbluray_la-clpi_parse.o' clang: error: no such file or directory: 'src/libbluray/bdnav/.libs/libbluray_la-extdata_parse.o' clang: error: no such file or directory: 'src/libbluray/bdnav/.libs/libbluray_la-index_parse.o' clang: error: no such file or directory: 'src/libbluray/disc/.libs/libbluray_la-udf_fs.o' clang: error: no such file or directory: 'src/file/.libs/libbluray_la-dir_posix.o' clang: error: no such file or directory: 'src/file/.libs/libbluray_la-dirs_xdg.o' clang: error: no such file or directory: 'src/file/.libs/libbluray_la-dl_posix.o' clang: error: no such file or directory: 'src/file/.libs/libbluray_la-file_posix.o' clang: error: no such file or directory: 'src/file/.libs/libbluray_la-mount.o' make[1]: *** [Makefile:1438: libbluray.la] Error 1 make[1]: Leaving directory '/home/sgreene/MythAndroid/packaging/android/libs/libbluray' make: *** [Makefile:1055: all] Error 2

Steve

…

On Sat, Dec 30, 2023 at 11:21 PM nietu ***@***.***> wrote: @sgreene820 <https://github.com/sgreene820> I did overcome this issue [javac] error: Source option 5 is no longer supported. Use 6 or later. [javac] error: Target option 1.5 is no longer supported. Use 1.6 or later. by using openjdk version 11 in ubuntu. Any more fresh java version failed — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASQW2SY77TYUQQ6DQL2SUALYMDR4BAVCNFSM6AAAAAAX3MF7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGY3DMOBTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mspieth]

Ill look at this in the next few days.

[sgreene820]

Previous may not be valid, because I failed to "make clean". Incidentally, on recommendation from this thread I installed openjdk locally, which wasn't present and the compile didn't object to the absence. Below is the more current (and familiar) javac error: compile:

[javac] /home/sgreene/MythAndroid/packaging/android/libs/libbluray/src/libbluray/bdj/build.xml:26: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds [javac] Compiling 33 source files to /home/sgreene/MythAndroid/packaging/android/libs/libbluray/src/libbluray/bdj/build [javac] warning: [options] bootstrap class path not set in conjunction with -source 5 [javac] error: Source option 5 is no longer supported. Use 7 or later. [javac] error: Target option 5 is no longer supported. Use 7 or later. BUILD FAILED /home/sgreene/MythAndroid/packaging/android/libs/libbluray/src/libbluray/bdj/build.xml:26: Compile failed; see the compiler error output for details. Total time: 0 seconds make[1]: *** [Makefile:2902: all-local] Error 1 make[1]: Leaving directory '/home/sgreene/MythAndroid/packaging/android/libs/libbluray' make: *** [Makefile:1055: all] Error 2

Build environment is Linux Mint 21.2 on an laptop running Ryzen 7 6****.

…

On Tue, Jan 2, 2024 at 4:49 PM Mark Spieth ***@***.***> wrote: Ill look at this in the next few days. — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASQW2S2K2HLH6A72C2ERNDLYMR6FNAVCNFSM6AAAAAAX3MF7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGYYDONZRG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[IcoDeveloper]

I've just spent some time getting the compile for fixes/34 to work in the docker environment;
ran into the same build error there; fixed by switching to latest libbluray in makelibs.sh (LIBBLURAYVER=1.3.4)