Skip to content

Issues with elasticsearch_host changes #86

@Gillingham

Description

@Gillingham
  1. elasticsearch_host seems to now require a protocol prefix, but this change isnt documented anywhere, the sample props still have elasticsearch_host=[YourElasticsearchHost]
  2. fixed Elasticsearch http https validation #80 Doesn't actually catch the missing prefix as the check happens after the curl call. If the prefix is missing the curl call will fail and return before the check for the prefix happens.
  3. Since it's no longer just the host, the variable itself should get renamed, maybe .._host and ..._port should both go away and be replaced with elasticsearch_url or something along those lines.

For future consideration, how should breaking changes like this be announced/documented? I was surprised when trying out the beta build that our install now fails, but I had to dig through github issues and commits/source code to find out why, not an ideal process. Maybe this project needs a public CHANGELOG ala Keep a Changelog in repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions