-
Notifications
You must be signed in to change notification settings - Fork 10
Issues with elasticsearch_host changes #86
Copy link
Copy link
Open
Milestone
Description
elasticsearch_hostseems to now require a protocol prefix, but this change isnt documented anywhere, the sample props still haveelasticsearch_host=[YourElasticsearchHost]- fixed Elasticsearch http https validation #80 Doesn't actually catch the missing prefix as the check happens after the curl call. If the prefix is missing the curl call will fail and return before the check for the prefix happens.
- Since it's no longer just the host, the variable itself should get renamed, maybe
.._hostand..._portshould both go away and be replaced withelasticsearch_urlor something along those lines.
For future consideration, how should breaking changes like this be announced/documented? I was surprised when trying out the beta build that our install now fails, but I had to dig through github issues and commits/source code to find out why, not an ideal process. Maybe this project needs a public CHANGELOG ala Keep a Changelog in repo.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels