Skip to content

Improve error messages for out of bound weather data #1226

@brtietz

Description

@brtietz

Overall this is a big improvement and the error messages work well for irradiance, time, and albedo. The highlighted values from hour 2 all should generate warnings or errors, but PVWattsv8 runs just fine with them:

379002024-843ae8c3-69d2-41cc-8aa6-0f4cf35edb24

Do we want to fix these as a part of this PR, another issue, or are these unimportant?

Tdew will throw an error if the heat transfer temperature model is chosen. The other place it is used is the POA decomposition, would need to check error handling there.
Wdir similarly is only referenced by the heat transfer temperature model and should have an error check there (0-360, non-nan)

Pressure and Tamb are treated as optional inputs to irrad same as elevation, so they get rewritten as 1013.25 mbar and 15 degC if the values are not valid (isnan check for each, > 800 mbar for pres). But Tamb should likely throw an error from the thermal model.

Wind speed should likely have a positive sanity check and an upper bound in the thermal models.

I vote for making a new issue for improving error messages and handling at the thermal model level.

Originally posted by @mjprilliman in #1219 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions