Skip to content

Commit 74ff456

Browse files
authored
refactor(config): update deprecated field handling for remove_thinking_traces (#1196)
1 parent 343b759 commit 74ff456

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

nemoguardrails/rails/llm/config.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
from pydantic import (
2626
BaseModel,
2727
ConfigDict,
28-
ValidationError,
28+
Field,
2929
model_validator,
3030
root_validator,
3131
validator,
@@ -77,7 +77,7 @@ class ReasoningModelConfig(BaseModel):
7777
)
7878
remove_thinking_traces: Optional[bool] = Field(
7979
default=None,
80-
description="[DEPRECATED] Use remove_reasoning_traces instead. For reasoning models (e.g. DeepSeek-r1), if the output parser should remove thinking traces.",
80+
deprecated="The `remove_thinking_traces` field is deprecated use remove_reasoning_traces instead.",
8181
)
8282
start_token: Optional[str] = Field(
8383
default="<think>",
@@ -89,17 +89,9 @@ class ReasoningModelConfig(BaseModel):
8989
)
9090

9191
@model_validator(mode="after")
92-
def handle_deprecated_field(self) -> "ReasoningModelConfig":
93-
"""Handle the deprecated remove_thinking_traces field."""
92+
def _migrate_thinking_traces(self) -> "ReasoningModelConfig":
93+
# If someone uses the old field, propagate it silently
9494
if self.remove_thinking_traces is not None:
95-
import warnings
96-
97-
warnings.warn(
98-
"The 'remove_thinking_traces' field is deprecated and will be removed in 0.15.0 version. "
99-
"Please use 'remove_reasoning_traces' instead.",
100-
DeprecationWarning,
101-
stacklevel=2,
102-
)
10395
self.remove_reasoning_traces = self.remove_thinking_traces
10496
return self
10597

@@ -472,7 +464,7 @@ class OutputRails(BaseModel):
472464
description="Configuration for streaming output rails.",
473465
)
474466

475-
apply_to_reasoning_traces: bool = Field(
467+
apply_to_reasoning_traces: Optional[bool] = Field(
476468
default=False,
477469
description=(
478470
"If True, output rails will apply guardrails to both reasoning traces and output response. "

0 commit comments

Comments
 (0)