-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Regression: nemoclaw logs --follow broken again (was fixed in #424) #1146
Copy link
Copy link
Closed
Labels
NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).Use this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingSomething isn't working
Description
Summary
nemoclaw <name> logs --follow fails with:
error: unexpected argument '--follow' found
tip: to pass '--follow' as a value, use '-- --follow'
Usage: openshell logs <NAME>
This is a regression of #424, which was fixed by #436 (merged Mar 19). The fix mapped --follow to --tail to match the OpenShell CLI. PR #953 (merged Mar 27) rewrote sandboxLogs() and reintroduced --follow instead of --tail.
Timeline
| Event | Detail |
|---|---|
| #424 filed | nemoclaw logs --follow broken (openshell sandbox logs didn't exist) |
| #436 merged (Mar 19) | Fixed: openshell sandbox logs → openshell logs, --follow → --tail |
| #953 merged (Mar 27) | Rewrote sandboxLogs() with runOpenshell() helper, regressed --tail back to --follow |
Reproduction
$ openshell --version
openshell 0.0.12
$ nemoclaw my-assistant logs --follow
error: unexpected argument '--follow' found
Command failed (exit 2): openshell logs my-assistant --follow
$ openshell logs my-assistant --tail
# works — streams live logsRoot cause
sandboxLogs() in bin/nemoclaw.js (line 668) passes --follow directly to openshell logs, but OpenShell expects --tail:
function sandboxLogs(sandboxName, follow) {
const args = ["logs", sandboxName];
if (follow) args.push("--follow"); // should be "--tail"
runOpenshell(args);
}Fix
One-line change: replace "--follow" with "--tail" in sandboxLogs(). The user-facing flag should stay as --follow (matches docker logs -f / kubectl logs -f conventions).
The test in cli.test.js (line 147) should also verify the arg passed to openshell is --tail, not --follow.
Environment
- NemoClaw: current
main(a1a93c2) - OpenShell: 0.0.12
- Platform: DGX Spark (ARM64, Ubuntu 24.04)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
NemoClaw CLIUse this label to identify issues with the NemoClaw command-line interface (CLI).Use this label to identify issues with the NemoClaw command-line interface (CLI).bugSomething isn't workingSomething isn't working