Vouch request — security fixes for install.sh and L7 proxy #661
Closed
latenighthackathon
started this conversation in
Vouch Request
Replies: 2 comments
-
|
/vouch |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
@latenighthackathon has been vouched by @johntmyers. You can now submit pull requests to OpenShell. Welcome aboard. Please read CONTRIBUTING.md before submitting. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi team,
I filed two security issues on OpenShell and would like to contribute fixes:
Issue #638 —
install.shfollows redirects viaresolve_redirect()without validating that the final URL still points togithub.com/NVIDIA/OpenShell. If GitHub's redirect were ever poisoned (compromised CDN, DNS hijack), the installer would silently download from an attacker-controlled origin. My fix adds origin validation after redirect resolution and caps redirect depth indownload().Issue #637 — The L7 proxy in
rest.rsandinference.rsaccepts multipleContent-Lengthheaders and silently keeps the last value. Per RFC 7230 §3.3.3, differing Content-Length values must be rejected — otherwise an attacker can cause the proxy and downstream server to disagree on message boundaries (CWE-444 request smuggling). My fix detects conflicting duplicate CL headers and rejects with HTTP 400.I already submitted PRs #659 and #660 but they were auto-closed by the vouch bot. Happy to resubmit once vouched.
I also have contributions on NemoClaw (PRs #1023, #1024, #1068-1071) for context on my work in the NVIDIA ecosystem.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions