Skip to content

Commit d00e453

Browse files
committed
skip if < 12
1 parent 9fcdeeb commit d00e453

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

cuda_core/cuda/core/experimental/_memory.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,6 @@ def __init__(self, reserved: bytes, size):
221221
self.reserved = reserved
222222
self._size = size
223223

224-
def resize(self, new_size):
225-
raise NotImplementedError("Cannot resize an IPC buffer")
226-
227224
def close(self):
228225
raise NotImplementedError("Cannot close an IPC buffer directly")
229226

@@ -233,17 +230,12 @@ def copy_from(self, src, size=None):
233230
def copy_to(self, dst, size=None):
234231
raise NotImplementedError("Cannot copy from an IPC buffer")
235232

236-
def __del__(self):
237-
# Override to prevent automatic closing
238-
pass
239-
240233
def __reduce__(self):
241-
# Save only the reserved bytes, not the whole CUmemPoolPtrExportData object
234+
# This is subject to change if the CumemPoolPtrExportData struct/object changes.
242235
return (self._reconstruct, (self.reserved, self._size))
243236

244237
@classmethod
245238
def _reconstruct(cls, reserved, size):
246-
# Create new instance
247239
instance = cls(reserved, size)
248240
return instance
249241

cuda_core/tests/test_memory.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
from cuda.core.experimental import Device
2424
from cuda.core.experimental._memory import Buffer, MemoryResource, Mempool
25-
from cuda.core.experimental._utils import handle_return
25+
from cuda.core.experimental._utils import get_binding_version, handle_return
2626

2727

2828
class DummyDeviceMemoryResource(MemoryResource):
@@ -296,6 +296,10 @@ def test_mempool():
296296
)
297297
def test_mempool_properties(property_name, expected_type):
298298
"""Test all properties of the Mempool class."""
299+
# skip test if cuda version is less than 12
300+
if get_binding_version() < (12, 0):
301+
pytest.skip("Test requires CUDA 12 or higher")
302+
299303
device = Device()
300304
device.set_current()
301305
pool_size = 2097152 # 2MB size
@@ -392,6 +396,8 @@ def mempool_child_process(importer, queue):
392396

393397

394398
def test_ipc_mempool():
399+
if get_binding_version() < (12, 0):
400+
pytest.skip("Test requires CUDA 12 or higher")
395401
# Set multiprocessing start method before creating any multiprocessing objects
396402
multiprocessing.set_start_method("spawn", force=True)
397403

0 commit comments

Comments
 (0)