From a5aa2c9778acb088b499399498ed4b72bc54e1d9 Mon Sep 17 00:00:00 2001
From: saschabuehrle <sascha.buehrle@gmail.com>
Date: Thu, 19 Mar 2026 18:12:47 +0100
Subject: [PATCH] fix: reuse explicit profile options for matching implicit
 profiles (fixes #19)

---
 .../src/multistorageclient/config.py          | 17 +++++--
 .../unit/test_implicit_profile_config.py      | 47 +++++++++++++++++++
 2 files changed, 61 insertions(+), 3 deletions(-)
 create mode 100644 multi-storage-client/tests/test_multistorageclient/unit/test_implicit_profile_config.py

diff --git a/multi-storage-client/src/multistorageclient/config.py b/multi-storage-client/src/multistorageclient/config.py
index d68adf9..f4fc563 100644
--- a/multi-storage-client/src/multistorageclient/config.py
+++ b/multi-storage-client/src/multistorageclient/config.py
@@ -1492,9 +1492,20 @@ def from_file(
                     # Verify it's a supported protocol
                     if protocol not in SUPPORTED_IMPLICIT_PROFILE_PROTOCOLS:
                         raise ValueError(f'Unsupported protocol in implicit profile: "{protocol}"')
-                    implicit_profile_config = create_implicit_profile_config(
-                        profile_name=profile, protocol=protocol, base_path=bucket
-                    )
+
+                    implicit_profile_name = f"{protocol}-{bucket}"
+                    existing_profile = merged_profiles.get(implicit_profile_name)
+                    if (
+                        existing_profile
+                        and existing_profile.get("storage_provider", {}).get("type")
+                        == PROTOCOL_TO_PROVIDER_TYPE_MAPPING[protocol]
+                        and existing_profile.get("storage_provider", {}).get("options", {}).get("base_path") == bucket
+                    ):
+                        implicit_profile_config = {"profiles": {profile: copy.deepcopy(existing_profile)}}
+                    else:
+                        implicit_profile_config = create_implicit_profile_config(
+                            profile_name=profile, protocol=protocol, base_path=bucket
+                        )
                 else:
                     raise ValueError(f'Invalid implicit profile format: "{profile}"')
             else:
diff --git a/multi-storage-client/tests/test_multistorageclient/unit/test_implicit_profile_config.py b/multi-storage-client/tests/test_multistorageclient/unit/test_implicit_profile_config.py
new file mode 100644
index 0000000..5a5e1c0
--- /dev/null
+++ b/multi-storage-client/tests/test_multistorageclient/unit/test_implicit_profile_config.py
@@ -0,0 +1,47 @@
+# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+from multistorageclient import StorageClientConfig
+
+
+def test_implicit_profile_reuses_matching_explicit_profile_options(monkeypatch) -> None:
+    msc_config = {
+        "profiles": {
+            "s3-my-bucket": {
+                "storage_provider": {
+                    "type": "s3",
+                    "options": {
+                        "base_path": "my-bucket",
+                        "endpoint_url": "https://my-endpoint.s3.com",
+                        "region_name": "us-west-2",
+                    },
+                }
+            }
+        }
+    }
+
+    monkeypatch.setattr(
+        StorageClientConfig,
+        "read_msc_config",
+        staticmethod(lambda config_file_paths=None: (msc_config, "/tmp/msc.yaml")),
+    )
+    monkeypatch.setattr("multistorageclient.config.read_rclone_config", lambda: ({}, None))
+
+    captured = {}
+
+    def fake_from_dict(config_dict, profile="__filesystem__", skip_validation=False, telemetry_provider=None):
+        captured["config_dict"] = config_dict
+        captured["profile"] = profile
+        captured["skip_validation"] = skip_validation
+        return profile
+
+    monkeypatch.setattr(StorageClientConfig, "from_dict", staticmethod(fake_from_dict))
+
+    result = StorageClientConfig.from_file(profile="_s3-my-bucket")
+
+    assert result == "_s3-my-bucket"
+    assert captured["profile"] == "_s3-my-bucket"
+    assert captured["skip_validation"] is True
+    implicit_profile = captured["config_dict"]["profiles"]["_s3-my-bucket"]
+    assert implicit_profile["storage_provider"]["options"]["endpoint_url"] == "https://my-endpoint.s3.com"
+    assert implicit_profile["storage_provider"]["options"]["region_name"] == "us-west-2"