Skip to content

Investigate caching by nypl-data-api-client & disable? #87

@kfriedman

Description

@kfriedman

I believe the (unfortunate) default behavior of the nypl-data-api-client is to have caching enabled (see: https://github.com/NYPL-discovery/node-nypl-data-api-client/blob/master/README.md#clientget-path-opts).

This presents problems when there isn't a clear expiration policy or an API returns a bad response and the bad response gets cached. This happened yesterday during our Sierra issues when bad Patron information was cached by the deliveryLocationsByBarcode endpoint. I was forced to bounce the server to resolve the issue.

@EdwinGuzman also had a similar issue with the Discovery UI so we can compare notes with him.

If caching is enabled, should we disable it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions