-
-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Enhance AddScene component to allow directly updating scenes #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I've been asked this before, but this has consequences on the Zigbee side that need testing, Z2M only ever used this to store new scenes, we don't really know how devices will behave (if they will follow spec, fail, make a mess...). The handling of scenes in the Zigbee spec is a little strange/convoluted, so, that makes it more prone to spec-deviations.
Scene stuff definitely needs some love though. We should be able to expand with other commands & co too. This month was bind/report, I guess next month can be scenes 😁 |
|
I knew it couldn't be that easy! :D |
|
I think we're better off testing the store scene "as update" on a few devices to see how well it's received/processed. The problem with chaining commands is the potential for failure of any command in the chain, and the state weirdness that could ensue. I was thinking of investigating the whole scene thing a bit further, and seeing if we can improve the overall handling, there are a lot more commands than just store/recall in the spec. Also, scene stuff is currently handled via converters in ZHC, but really, I think it might benefit from a move to ZH (it's spec). Similar to what is currently being done for other stuff like bind & report, we should be able to properly align device state with Z2M state, to avoid potential out-of-sync problems (scene on device but not in Z2M or vice versa). |
|
Makes sense. 🤔 Currently I tested it with one device only in my test network and it was working. Do you know how I can replace this build with the build shipped with the home assistant addon, so I can test it with my other devices too? I see, would be cool if the scene stuff was improved! I'm sadly not that deep into zigbee and Z2M yet, so not sure if/how I could help you? |
|
If you are using the add-on, it should just be about replacing the content of the nginx dir with the built I already started working on the scene stuff from the lower levels, but next release of Z2M will get quite a few changes, and there are a lot of changes with that one alone, so, don't want to pile up too much, and definitely won't be ready anyway. Will be in a release after new year, if we can get somewhere good with it 😉 |
|
I connected my custom build to my Zigbee2MQTT instance running in Home Assistant and tested the feature with my groups. My largest group has 28 members, mostly Philips Hue devices, but also Osram, Sonoff, MiBoxer, and Tuya. Updating scenes like this worked. :) |
Enhances the
AddScenecomponent, allowing scenes to be updated directly instead of requiring them to be deleted first.Kooha-2025-11-22-23-11-09.webm