Skip to content

Not all classes are aligned with guice approach #199

@al-matushkin

Description

@al-matushkin

Describe the bug

There are several instances where we have inconsistent DI setup which should be addressed

*** Confluence client builder alignment with guice approach

// TODO: @resource is not working yet, ApplicationContext update required.
// Client and Vertx are passed in constructor so far;

Currently ConfluenceClientBuilder seems to be duplicating the guice provider mechanism, in a very similar way. Builder might be removed and ConfluenceClient might be bound directly in module.

*** Git adapter builder alignment with guice approach

// TODO: @resource is not working yet, ApplicationContext update required.
// Client and Vertx are passed in constructor so far;

GitAdapterBuilder also seem to be duplicationg the guice provider mechanism, tough it also has handling of offline mode. Should consider provision of empty adapter instead of null in case of offline mode.

*** Slight violation of DI approach in GraphDumpSupport.restoreFromJson(Graph target, JsonObject dump)

// TODO: We shouldn't get here, but need to do it properly through DI

Need to handle this case properly using guice

To Reproduce

Version

No response

Logs

No response

Additional information

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions