Skip to content

[card-cache] optimizations to avoid deadlocks #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[card-cache] optimizations to avoid deadlocks #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions services/ui_backend_service/api/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,12 @@ async def get_card_content_by_hash(self, request):
task,
hash,
)
html_reload_script = "<script>window.needsReload = true;</script><body></body>"
if cards is None:
return web.Response(
content_type="text/html",
status=404,
body="Card not found for task. Possibly still being processed. Please refresh page to check again.",
body=html_reload_script,
Copy link
Contributor Author

@valayDave valayDave Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to UI coming soon!.

)

if cards and hash in cards:
Expand Down Expand Up @@ -275,7 +276,7 @@ async def get_card_data_for_task_async(
step_name=task.get("step_name"),
task_id=task.get("task_name") or task.get("task_id"),
)
await cache_client.cache_manager.register(pathspec)
await cache_client.cache_manager.register(pathspec, lock_timeout=0.2)
_local_cache = cache_client.cache_manager.get_local_cache(pathspec, card_hash)
if not _local_cache.read_ready():
# Since this is a data update call we can return a 404 and the client
Expand Down
Loading