Migration of share fails for name conflict

[DavidePrincipi]

In NS7, it is possible to create shares (ibays) that differ only by character casing, such as myshare and Myshare. However, from the SMB point of view, they are treated as the same share, meaning only one of them is actually used. When a similar setup is migrated to NS8, an error occurs.

Steps to reproduce

• In NS7, create two shares: Myshare and myshare.
• Upload some files using smbclient into MYSHARE, ensuring that the share name's case does not matter.
• Migrate to NS8.

Expected behavior

Migration completes without error.

Actual behavior

Migration aborts:

Now reading shares metadata from stdin...
Enabled share OtherShare1
Enabled share Myshare
Enabled share OtherShare2
ERROR: share myshare already exists.
Traceback (most recent call last):
  File "/home/samba1/.config/actions/import-module/80import_shares", line 46, in <module>
    subprocess.run(['podman', 'exec',
  File "/usr/lib64/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['podman', 'exec', '--interactive', '--env=RSYNCD_NETWORK=10.5.4.0/24', '--env=RSYNCD_ADDRESS=10.5.4.1', '--env=RSYNCD_PORT=20002', '--env=RSYNCD_USER=samba1', '--env=RSYNCD_PASSWORD=93309cb970559-5a1c-4e95-8609-9013281bb9c0', '--env=RSYNCD_SYSLOG_TAG=samba1', 'samba-dc', 'rsyncd-import-shares']' returned non-zero exit status 255.

Components

• core 3.4.6
• samba 2.3.3

See also

• https://mattermost.nethesis.it/nethesis/pl/wthbhihxutbjfby6msiozpurjr

---

Thanks to @lucagasparini

[DavidePrincipi]

In testing 2.3.4-dev.1

• Check the bug is not reproducible.
• Verify a validation error occurs if a share with the same name already exists, with a case-sensitive check.

[lucagasparini]

Test case VERIFIED