Waste of disk space due to stale Restic images

[DavidePrincipi]

Each module instance should have at least one scheduled backup. This means every module instance runs a Restic core container image and stores it in its local Podman image storage. When Core is updated, a new Restic image is pulled by each module. These image duplicates waste disk space, as old images are not cleaned up.

Steps to reproduce

• Install a module and run a backup for it
• Update Core
• Run the module backup.

Expected behavior

The old Restic image is removed.

Actual behavior

The old Restic image is retained.

~]# runagent -m collabora1 podman images
REPOSITORY                 TAG          IMAGE ID      CREATED        SIZE
ghcr.io/nethserver/restic  3.6.2        6990eadcb025  12 days ago    126 MB
ghcr.io/nethserver/restic  3.6.1        4c167d2f358c  2 weeks ago    126 MB
ghcr.io/nethserver/restic  3.5.0        730b989ed1cf  4 weeks ago    122 MB
ghcr.io/nethserver/restic  3.4.6        fe89673f1a9a  6 weeks ago    122 MB
ghcr.io/nethserver/restic  3.4.5        b293667142fa  7 weeks ago    122 MB
ghcr.io/nethserver/restic  3.4.4        ac2bd7bbaf8c  2 months ago   122 MB
ghcr.io/nethserver/restic  3.4.1        f14127cd7f59  2 months ago   122 MB
ghcr.io/nethserver/restic  3.4.0        de733919241e  3 months ago   122 MB
ghcr.io/nethserver/restic  3.3.1        9cb472ba3b32  3 months ago   122 MB
ghcr.io/nethserver/restic  3.3.0        dc0ceea62034  3 months ago   122 MB
ghcr.io/nethserver/restic  3.2.5        17a283a62c94  4 months ago   122 MB
ghcr.io/nethserver/restic  3.2.4        1c06abec9544  4 months ago   122 MB
ghcr.io/nethserver/restic  3.2.2        ffa90cea73e2  5 months ago   122 MB
ghcr.io/nethserver/restic  3.1.4        9d0e1fc731f3  5 months ago   122 MB
ghcr.io/nethserver/restic  3.1.3        cd2bca1f4979  5 months ago   122 MB
ghcr.io/nethserver/restic  3.1.2        c7ee3f5cc1a4  5 months ago   122 MB
ghcr.io/nethserver/restic  3.1.1        a7621602034a  5 months ago   122 MB
ghcr.io/nethserver/restic  3.0.0        d71585df829f  6 months ago   122 MB
ghcr.io/nethserver/restic  2.10.0       fba98e06b4af  6 months ago   89.4 MB
ghcr.io/nethserver/restic  2.9.5        af05ece7daa1  6 months ago   89.4 MB
docker.io/collabora/code   23.05.5.4.1  2158ca0956c2  16 months ago  1.36 GB

Components

• Core 3.6.2

See also

• Discussion https://mattermost.nethesis.it/nethesis/pl/j9ux5emkrjddfkkp6srd4514zc

---

Thanks to @nrauso

[stephdl]

QA

target version ghcr.io/nethserver/core:3.7.0-dev.5

• must be tested on debian and rocky linux
• install core version 3.6.4
• download some restic images for some modules

runagent -m traefik1
podman pull ghcr.io/nethserver/restic:3.6.0
podman pull ghcr.io/nethserver/restic:3.6.1
podman pull ghcr.io/nethserver/restic:3.6.2
podman pull ghcr.io/nethserver/restic:3.6.3
podman pull ghcr.io/nethserver/restic:3.6.4
# verify the images
podman images

• update the core to core:3.7.0-dev.5
• verify in traefik the restic images must have been cleaned

runagent -m traefik1
podman images

[mrmarkuz]

Verified

• Restic images are cleaned
• Working on Rocky and Debian