Migration to orphan single node cluster fails

[DavidePrincipi]

If the NS8 cluster is constituted by a single node formerly part of a multi-node cluster with NODE_ID > 1 the migration tool is not capable of binding apps to it.

Steps to reproduce

• Create a NS8 cluster
• Join a worker node and promote it to leader
• Remove the old leader
• Start NS7 migration with the Migration Tool

Expected behavior

When an app migration starts, the Migration Tool automatically selectes the new leader ID, e.g. 2.

Actual behavior

• An hardcoded default NODE_ID is used: 1

Bind operation fails with this message:

Assertion failed
  File "/var/lib/nethserver/cluster/actions/import-module/50import", line 39, in <module>
    agent.assert_exp(rsyncd_addr)

Components

• nethserver-ns8-migration-1.3.1-1.ns7.x86_64

See also

• Discussion: https://mattermost.nethesis.it/nethesis/pl/sk4waenubpgnzpzpaud3np4j5o

[stephdl]

QA

target : yum install http://packages.nethserver.org/nethserver/7.9.2009/testing/x86_64/Packages/nethserver-ns8-migration-1.3.1-1.3.g1767a74.ns7.x86_64.rpm

case 1 (one node)

• reproduce the configuration above with the node 2 as a new leader and the node 1 removed
• install some apps on a NS7
• install nethserver-ns8-migration
• migrate some apps to the leader

case 2 (multi node)

• reproduce the configuration above with the node 2 as a new leader and the node 1 removed, then add a new node (node3)
• install some apps on a NS7
• install nethserver-ns8-migration
• migrate some apps to the leader and other apps to node 3

No issues are expected

[nethbot]

in 7.9.2009/testing:

• nethserver-ns8-migration-1.3.1-1.3.g1767a74.ns7.x86_64.rpm x86_64