Meta .json gets lost between Push and Pop frames

[SamNChiet]

Hey hey! I appreciate this project -
I need to add some additional data to my frames, but when I pop my frames, the JSON of the pushed packet is just missing. It's as if, when PopH264 pushes to the encoder, it forgets to preserve that JSON, and all that's left is the JSON added by the pop function - ignoring TPacket.mEncodeMeta.mInputMeta.
I don't know if that's actually what's happening, but it's making things a little challenging rn haha. Still digging myself - but does anyone have an idea what might be going on?
I'm using the latest C# and a DLL built from this repository, not the UPM package.

[SamNChiet]

I spent so much time in the C++ I didn't see the obvious -

This struct shouldn't exist.

The actual struct containing the data is EncoderFrameData

Deleting that empty struct and replacing it with the name of this one, in the .cs file, seems to fix it.

[SoylentGraham]

That makes sense!
I feel like (and i havent touched the decoder for quite a while) like i wanted to make it so you could define the popped meta so you could send what you want in, and get it back;

That said, as i type this, i feel like i may have dropped that for just making framenumbers/times very correct so the client side can associate data that way...

Maybe this c# side is just a bit rigid, thus your change makes sense :)

[SoylentGraham]

Oh that said;
Frame data is data the encoder NEEDS.
Meta is data you associate with a frame, but not what the encoder needs. The names of the types are very explicitly named; data != meta.

I may just have to look at this a lot more closely(that might not be for a while though)

[SamNChiet]

Ah, yeah it seems very inconsistent whether data makes it through the pipeline now haha. I've undone my change.
I'm just trying to figure out how to tag frames with some additional information so I can know whether to free the resources associated with them when they make it to the other end of the pipe.
I'm super open to alternative ways of doing that though!

[SamNChiet]

I'm very likely doing something I'm not supposed to due to not understanding the 'correct' way.
Also, thanks for your work on this library! It's super helpful.

[SoylentGraham]

Im pretty sure like the decoder, I just associate other data with the frame number, and the frame number going in should be what comes out, and they should be unique (unless possibly the meta, SPS/PPS etc) so shouldnt ever double delete or anything