From 6687829956b6ba7912c6f751c492ce11489ab112 Mon Sep 17 00:00:00 2001 From: Riccardo Degan Date: Sun, 28 Jul 2013 17:54:32 +0200 Subject: [PATCH 1/4] If there is a error reopen conection --- lib/pushmeup/apns/core.rb | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/pushmeup/apns/core.rb b/lib/pushmeup/apns/core.rb index 5d74778..cdbbb34 100644 --- a/lib/pushmeup/apns/core.rb +++ b/lib/pushmeup/apns/core.rb @@ -23,8 +23,18 @@ def self.send_notifications(notifications) sock, ssl = self.open_connection notifications.each do |n| - ssl.write(n.packaged_notification) + # Write message to APNS + puts ssl.write(n.packaged_notification) + if IO.select([ssl], nil, nil, 5) + read_buffer = ssl.read(6) + puts "read_buffer:#{read_buffer}" + # close and reopen connection in case of error + ssl.close + sock.close + sock, ssl = self.open_connection + puts "Reopen connectio" end + end ssl.close sock.close From 6d635c6a9bbbaa10cad4ae3aae8264730c015043 Mon Sep 17 00:00:00 2001 From: Andrea Beggiato Date: Tue, 30 Jul 2013 15:17:11 +0200 Subject: [PATCH 2/4] remove --- lib/pushmeup/apns/core.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pushmeup/apns/core.rb b/lib/pushmeup/apns/core.rb index cdbbb34..5ad45b5 100644 --- a/lib/pushmeup/apns/core.rb +++ b/lib/pushmeup/apns/core.rb @@ -25,7 +25,7 @@ def self.send_notifications(notifications) notifications.each do |n| # Write message to APNS puts ssl.write(n.packaged_notification) - if IO.select([ssl], nil, nil, 5) + if IO.select([ssl], nil, nil, 2) read_buffer = ssl.read(6) puts "read_buffer:#{read_buffer}" # close and reopen connection in case of error From baf570b2a1003e22706721254f561a3f9bd71840 Mon Sep 17 00:00:00 2001 From: Riccardo Degan Date: Wed, 31 Jul 2013 12:38:55 +0200 Subject: [PATCH 3/4] add logger --- lib/pushmeup/apns/core.rb | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/pushmeup/apns/core.rb b/lib/pushmeup/apns/core.rb index cdbbb34..c4afb32 100644 --- a/lib/pushmeup/apns/core.rb +++ b/lib/pushmeup/apns/core.rb @@ -21,18 +21,19 @@ def self.send_notification(device_token, message) def self.send_notifications(notifications) sock, ssl = self.open_connection - + pushmeLog = ActiveSupport::BufferedLogger.new(Rails.root.join('log/status.log')) notifications.each do |n| # Write message to APNS puts ssl.write(n.packaged_notification) - if IO.select([ssl], nil, nil, 5) + pushmeLog.info "Send #{n.device_token}" + if IO.select([ssl], nil, nil, 1) read_buffer = ssl.read(6) - puts "read_buffer:#{read_buffer}" + # puts "read_buffer:#{read_buffer}" # close and reopen connection in case of error ssl.close sock.close sock, ssl = self.open_connection - puts "Reopen connectio" + # puts "Reopen connection" end end From d3ba3bbc9a32db2fc16887fdea7fdf4453b37038 Mon Sep 17 00:00:00 2001 From: Riccardo Degan Date: Wed, 31 Jul 2013 14:29:33 +0200 Subject: [PATCH 4/4] Remove log --- lib/pushmeup/apns/core.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/pushmeup/apns/core.rb b/lib/pushmeup/apns/core.rb index 019ca6a..c60135d 100644 --- a/lib/pushmeup/apns/core.rb +++ b/lib/pushmeup/apns/core.rb @@ -21,14 +21,14 @@ def self.send_notification(device_token, message) def self.send_notifications(notifications) sock, ssl = self.open_connection - pushmeLog = ActiveSupport::BufferedLogger.new(Rails.root.join('log/pushmeup.log')) + # pushmeLog = ActiveSupport::BufferedLogger.new(Rails.root.join('log/pushmeup.log')) notifications.each do |n| # Write message to APNS puts ssl.write(n.packaged_notification) - pushmeLog.info "Send #{n.device_token}" + # pushmeLog.info "Send #{n.device_token}" if IO.select([ssl], nil, nil, 1) read_buffer = ssl.read(6) - pushmeLog.info "### Error for: #{n.device_token}" + # pushmeLog.info "### Error for: #{n.device_token}" # puts "read_buffer:#{read_buffer}" # close and reopen connection in case of error ssl.close