Reduce burden on the CPU testing suite#198
Merged
simone-silvestri merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
tests go from 1hr16 to 47m now sure if it is a great improvement |
glwagner
approved these changes
Apr 30, 2026
Member
glwagner
left a comment
glwagner
left a comment
There was a problem hiding this comment.
I think this is a necessary evil. But perhaps should go further. Are there any tests that can be moved to data downloading?
Member
|
I think this closes an issue right? |
Member
Author
|
deleted also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heaviest tests blow up the testing time on the CPU job.
These tests, however are also repeated on (faster) GPU workers. To speed up the testing infrastructure we keep the heaviest tests only on the GPU which is a more stringent testing hardware