Regrid by applying the regridder object to dst and src arrays#16
Merged
Regrid by applying the regridder object to dst and src arrays#16
regridder object to dst and src arrays#16Conversation
Refactor regrid function to improve clarity and performance.
Member
Author
|
This pattern is the same pattern as for Interpolations.jl and Dierckz.jl where you first build an intepolator object and then apply it as a functor (from the Dierckz.jl README):
|
navidcy
reviewed
Sep 26, 2025
| # Mixed cases | ||
| function (regridder::Regridder)(dst::DenseVector, src::AbstractVector) | ||
| regridder.src_temp .= src | ||
| return LinearAlgebra.mul!(dst, regridder.weights, regridder.src_temp) |
Member
There was a problem hiding this comment.
does LinearAlgebra.mul! return its first arg?
Member
Author
There was a problem hiding this comment.
I think so:
julia> A=[1.0 2.0; 3.0 4.0]; B=[1.0 1.0; 1.0 1.0]; Y = similar(B); mul!(Y, A, B)
2×2 Matrix{Float64}:
3.0 3.0
7.0 7.0
navidcy
approved these changes
Sep 26, 2025
Member
|
I'll test this with Oceananigans and merge if all seems good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@navidcy what do you think about this solution?