ui(score-card): remove fraction digits from displayed value#87
Merged
ui(score-card): remove fraction digits from displayed value#87
Conversation
Closes O2sa#85. One-line change: `{value.toFixed(2)}` -> `{value}` at line 21 of components/score-card.tsx to render whole numbers instead of two-decimal floats for improved readability, per the task list in the issue. Callers passing already-rounded numbers get the same output; callers that were previously relying on the forced two-decimal format (e.g. for consistent visual alignment of 3.00 vs 2.50) lose that formatting — which is the intended change per the issue.
|
@mvanhorn is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
Owner
|
Congratulations @mvanhorn 🎊 Your first contribution has been merged! 🚀 Thank you for helping improve the project. If you find this tool useful, please consider giving us a ⭐ star on GitHub—it helps more developers find our work! |
Contributor
Author
|
Thanks @O2sa! Happy to contribute — starred. |
Contributor
Author
|
Thanks for landing the score-card cleanup, @O2sa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85.
Single-line change at
components/score-card.tsx:21:Renders whole numbers (and natural float precision for non-integer values) instead of forcing two-decimal display, matching the issue's acceptance task list:
components/score-card.tsx{value.toFixed(2)}to{value}No other files changed. The component's only consumer of this display is the score card itself, and callers already pass rounded numbers in the common case.