Skip to content

docs: add compare API examples to README#92

Merged
O2sa merged 2 commits intoO2sa:mainfrom
nightcityblade:fix/issue-30
Apr 21, 2026
Merged

docs: add compare API examples to README#92
O2sa merged 2 commits intoO2sa:mainfrom
nightcityblade:fix/issue-30

Conversation

@nightcityblade
Copy link
Copy Markdown
Contributor

Fixes #30

Additionally, at the time of submission of this PR:

  • The referred issue is not blocked currently
  • All unittests passed after changes were made

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

Someone is attempting to deploy a commit to the osama's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

Thank you for the pull request! ✅

A maintainer will review this soon. Please be patient while we take a look. 🙌

Copy link
Copy Markdown
Owner

@O2sa O2sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better if put the full response and consider to use the default usernames of the ui.

Comment thread README.md Outdated
### Example request

```bash
curl "http://localhost:3000/api/compare?username=octocat&username=torvalds"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the domain to be a placeholder instead of http://localhost or it would be better if you remove it at all.

Suggested change
curl "http://localhost:3000/api/compare?username=octocat&username=torvalds"
GET "api/compare?username=octocat&username=torvalds"

Copy link
Copy Markdown
Owner

@O2sa O2sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better if put the full response and consider to use the default usernames of the ui.

@nightcityblade
Copy link
Copy Markdown
Contributor Author

Updated. I switched the compare example to a placeholder API path and used default-style usernames in the sample request.

@O2sa O2sa merged commit af6a006 into O2sa:main Apr 21, 2026
1 check failed
@github-actions
Copy link
Copy Markdown

Thank you, @nightcityblade! Another great contribution merged! 🚀

You've been a fantastic contributor! We truly appreciate your continued support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example requests and responses to README

2 participants