[IMP] l10n_it_fatturapa_out: XML validation prints nicer error msg

Author: aleuffre

l10n_it_fatturapa_out/tests/test_fatturapa_xml_validation.py

@@ -6,9 +6,11 @@
 
 import base64
 import re
+from unittest.mock import Mock
 
 from psycopg2 import IntegrityError
 
+import odoo
 from odoo import fields
 from odoo.exceptions import UserError
 from odoo.tests import Form, tagged
@@ -886,6 +888,83 @@ def test_no_tax_fail(self):
         )
         self.assertEqual(ue.exception.args[0], error_message)
 
+    def test_partner_no_address_fail(self):
+        """
+        - create an XML invoice where the customer has no city or zip
+
+        expect to fail with a proper message
+        """
+        self.res_partner_fatturapa_0.street = False
+        self.res_partner_fatturapa_0.city = False
+        invoice = self.invoice_model.create(
+            {
+                "invoice_date": "2016-06-15",
+                "partner_id": self.res_partner_fatturapa_0.id,
+                "journal_id": self.sales_journal.id,
+                "invoice_payment_term_id": self.account_payment_term.id,
+                "user_id": self.user_demo.id,
+                "move_type": "out_invoice",
+                "currency_id": self.EUR.id,
+                "invoice_line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "account_id": self.a_sale.id,
+                            "product_id": self.product_product_10.id,
+                            "name": "Mouse, Optical",
+                            "quantity": 1,
+                            "product_uom_id": self.product_uom_unit.id,
+                            "price_unit": 10,
+                            "tax_ids": [(6, 0, {self.tax_22.id})],
+                        },
+                    ),
+                    (
+                        0,
+                        0,
+                        {
+                            "account_id": self.a_sale.id,
+                            "product_id": self.product_order_01.id,
+                            "name": "Zed+ Antivirus",
+                            "quantity": 1,
+                            "product_uom_id": self.product_uom_unit.id,
+                            "price_unit": 4,
+                            "tax_ids": [(6, 0, {self.tax_22.id})],
+                        },
+                    ),
+                ],
+            }
+        )
+        invoice._post()
+        wizard = self.wizard_model.create({})
+        with self.assertRaises(UserError) as ue:
+            wizard.with_context({"active_ids": [invoice.id]}).exportFatturaPA()
+        error_msg = ue.exception.args[0]
+        error_fragments = [
+            f"Error processing invoice(s) {invoice.name}",
+            "Indirizzo",
+            "Comune",
+            "Activate debug mode to see the full error",
+        ]
+        for fragment in error_fragments:
+            self.assertIn(fragment, error_msg)
+
+        # Enter debug mode and add details
+        odoo.http._request_stack.push(
+            Mock(db=self.env.cr.dbname, env=self.env, debug=True)
+        )
+        wizard = self.wizard_model.create({})
+        with self.assertRaises(UserError) as ue:
+            wizard.with_context({"active_ids": [invoice.id]}).exportFatturaPA()
+        debug_error_msg = ue.exception.args[0]
+        debug_error_fragments = [
+            "Full error follows",
+            "Reason: value doesn't match any pattern of",
+            "class 'lxml.etree._Element'>",
+        ]
+        for fragment in error_fragments[:-1] + debug_error_fragments:
+            self.assertIn(fragment, debug_error_msg)
+
     def test_multicompany_fail(self):
         """
         - create two invoices in two different companies

l10n_it_fatturapa_out/wizard/efattura.py

@@ -261,7 +261,26 @@ def to_xml(self, env):
             # i controlli precedenti dovrebbero escludere errori di sintassi XML
             # with open("/tmp/fatturaout.xml", "wb") as o:
             #    o.write(etree.tostring(root, xml_declaration=True, encoding="utf-8"))
-            raise UserError("\n".join(str(e) for e in errors))
+            # Print error paths, as they can be helpful even for non-technical people
+            error_path_string = "\n- ".join(
+                err.path[err.path.index(":") + 1 :] for err in errors
+            )
+            error_msg = _(
+                "Error processing invoice(s) %(invoices)s.\n\n"
+                "Errors in the following fields:\n- %(error_path_string)s\n\n",
+                invoices=", ".join(
+                    inv.display_name for inv in template_values["invoices"]
+                ),
+                error_path_string=error_path_string,
+            )
+            # add details in debug mode
+            if env.user.user_has_groups("base.group_no_one"):
+                error_msg += _("Full error follows:\n\n") + "\n".join(
+                    str(e) for e in errors
+                )
+            else:
+                error_msg += _("Activate debug mode to see the full error.")
+            raise UserError(error_msg)
         content = etree.tostring(root, xml_declaration=True, encoding="utf-8")
         return content