From f08aa00c91dbbe81f52713a7bb5bc748d019f418 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Suniaga?= <suniagajose@gmail.com>
Date: Thu, 16 Apr 2026 17:51:41 -0600
Subject: [PATCH] [FIX] checks_odoo_module_xml: return bytes from
 _get_first_tag

When the XML file contains no tag (e.g. an empty file), _get_first_tag
returned the Python str ''. The success branch returns bytes from
b' '.join(buffer), and check_xml_header consumes the result with
first_tag.startswith(b'<?xml '), which raises:

    TypeError: startswith first arg must be str or a tuple of str, not bytes

Return b'' in the no-tag path so both branches are type-consistent and
downstream bytes operations keep working.
---
 src/oca_pre_commit_hooks/checks_odoo_module_xml.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/oca_pre_commit_hooks/checks_odoo_module_xml.py b/src/oca_pre_commit_hooks/checks_odoo_module_xml.py
index 4cbf2b9..34c3914 100644
--- a/src/oca_pre_commit_hooks/checks_odoo_module_xml.py
+++ b/src/oca_pre_commit_hooks/checks_odoo_module_xml.py
@@ -117,7 +117,7 @@ def _get_first_tag(self, fileobj_xml):
                 if line_stripped not in buffer:
                     buffer.append(line_stripped)
                 return b" ".join(buffer), buffer_lineno
-        return "", 0
+        return b"", 0
 
     def update_node(self, manifest_data):
         """Update the etree node of the manifest_data.