From f95a57943200af903d961e76a41d03f579c79a5f Mon Sep 17 00:00:00 2001 From: Julia Elizondo Date: Wed, 27 Nov 2024 13:43:45 -0300 Subject: [PATCH 1/2] [FIX] sale_product_pack: _get_update_prices_lines refactor --- sale_product_pack/models/sale_order.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/sale_product_pack/models/sale_order.py b/sale_product_pack/models/sale_order.py index 00f518fe7..ea6ed0639 100644 --- a/sale_product_pack/models/sale_order.py +++ b/sale_product_pack/models/sale_order.py @@ -60,12 +60,7 @@ def write(self, vals): def _get_update_prices_lines(self): res = super()._get_update_prices_lines() - result = self.order_line.browse() - index = 0 - while index < len(res): - line = res[index] - result |= line - index += 1 - if line.product_id.pack_ok and line.pack_type == "detailed": - index += len(line.product_id.pack_line_ids) - return result + return res.filtered( + lambda line: not line.pack_parent_line_id + or line.pack_parent_line_id.pack_component_price == "detailed" + ) From af9db8ed2fa6f6c3efd003a3ee05ad0cbafd325e Mon Sep 17 00:00:00 2001 From: jue-adhoc Date: Thu, 28 Nov 2024 13:03:08 -0300 Subject: [PATCH 2/2] made changes applicable to version 16.0 Co-authored-by: augusto-weiss <90717087+augusto-weiss@users.noreply.github.com> --- sale_product_pack/models/sale_order.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sale_product_pack/models/sale_order.py b/sale_product_pack/models/sale_order.py index ea6ed0639..ea748e216 100644 --- a/sale_product_pack/models/sale_order.py +++ b/sale_product_pack/models/sale_order.py @@ -60,7 +60,4 @@ def write(self, vals): def _get_update_prices_lines(self): res = super()._get_update_prices_lines() - return res.filtered( - lambda line: not line.pack_parent_line_id - or line.pack_parent_line_id.pack_component_price == "detailed" - ) + return res.filtered(lambda line: not line.pack_parent_line_id)