-
Notifications
You must be signed in to change notification settings - Fork 116
Description
Currently a glacier fails completely if it grows out of the domain at any given time when doing projections (error message: "Glacier exceeeds boundaries"). That means, we do not get any information on the glacier projections, even not for those years where the glacier has not yet grown out of the domain.
Maybe it would be nice to output the projections until the year where the glacier fails, and then add NaNs after the time period where the glacier "grew" out of the boundary. Eventually one could also tag the output by some additional information to clarify the "partial failure" of that glacier.
This would be specifically interesting for very long "stabilisation" or overshoot scenarios at relatively cold final temperatures.
I am not 100% sure where to best start to tackle this issue, but I guess, running a projection where a glacier grows out of the boundary, as in this test here:
oggm/oggm/tests/test_numerics.py
Line 1204 in 1c68657
| def test_raise_on_boundary(self): |
Eventually it would mean to output the data just before this line here :
Line 187 in 1c68657
| raise RuntimeError('Glacier exceeds boundaries') |
run_until_and_store )or adapt the "stop_if_border=False" within
Line 176 in 1c68657
| def run_until(self, y1, stop_if_border=False): |